Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2011-12-20
Last edited by fml2 - 2011-12-22

FS#12470 - Rename "mp3entry.embed_albumart" to "mp3entry.has_embedded_albumart"

The patch does just what the title says (and nothing else). I think the new name more clearly states what the field means. I hope I catched all occurences.

In a separate patch I'll probably rename the field "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet".

   has_embedded_albumart.diff (4.4 KiB)
Closed by  fml2
2011-12-22 18:54
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r31405

nickp commented on 2011-12-21 06:05

Excellent patch, I've no excuse now ;)

kugel. commented on 2011-12-21 07:11

Just nit-picking, but how about moving the bool into the struct as done with cuesheet ("bool present;")?

fml2 commented on 2011-12-21 10:15

This is not nit picking, it's a matter of style. I've seen that difference. In the planned cuesheet patch I'd move the boolean field out of the structure, i.e. make it like album art. I like it more that way, i.e. have a separate field telling whether the structure can be used, and not making the field part of the structure itself.

But that would be part of a separate patch.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing