- Status Closed
- Percent Complete
- Task Type Patches
- Category ID3 / meta data
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.9
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Alexander Levin - 2011-12-20
Last edited by Alexander Levin - 2011-12-22
Opened by Alexander Levin - 2011-12-20
Last edited by Alexander Levin - 2011-12-22
FS#12470 - Rename "mp3entry.embed_albumart" to "mp3entry.has_embedded_albumart"
The patch does just what the title says (and nothing else). I think the new name more clearly states what the field means. I hope I catched all occurences.
In a separate patch I'll probably rename the field "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet".
has_embedded_albumart.diff
(4.4 KiB)
Closed by Alexander Levin
2011-12-22 18:54
Reason for closing: Accepted
Additional comments about closing:
2011-12-22 18:54
Reason for closing: Accepted
Additional comments about closing:
Committed as r31405
Excellent patch, I've no excuse now ;)
Just nit-picking, but how about moving the bool into the struct as done with cuesheet ("bool present;")?
This is not nit picking, it's a matter of style. I've seen that difference. In the planned cuesheet patch I'd move the boolean field out of the structure, i.e. make it like album art. I like it more that way, i.e. have a separate field telling whether the structure can be used, and not making the field part of the structure itself.
But that would be part of a separate patch.