Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nickp - 2011-12-21
Last edited by nickp - 2011-12-22

FS#12472 - Permanent time settings menu

The current Settings > Time & Date menu contains items that can operate without a RTC.

The problem is that this menu only exists when the device has a RTC, otherwise the remaining items (currently sleep timer related) are shifted into the root settings menu.

This patch creates a new permanent Time Settings menu which holds these and other time related items. The existing Time & Date menu becomes a sub menu of it (on RTC targets), with most of it’s items stripped out.

Closed by  nickp
2011-12-22 07:19
Reason for closing:  Rejected
Additional comments about closing:  

Not much interest in this menu layout

nickp commented on 2011-12-21 11:44

The patch is currently pretty raw, I’ll work on updating it and the manual if there’s interest.

I don’t tihnk this patch is a good idea. The 3 settings left on non-rtc targets (2x sleep timer, 1x idle poweroff) have absolutely nothing to do with “time settings” and would become unobvious and possibly lost there. Admittedly t&d arn’t right for these also.

Of course, we could do this but have the lang string different on non-rtc targets, but doesn’t that negate much of the point of the patch? (and call it what? startup/shutdown options?)

nickp commented on 2011-12-21 13:36

I agree.

The real point of the patch is a permanent home for non RTC settings.

Unfortunately fixing this invariably grinds to a halt due to the finer points of semantics.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing