• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2011-12-21
Last edited by fml2 - 2011-12-22

FS#12473 - Rename "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet" and pull out a field

This patch renames "mp3entry.embed_cuesheet" to "mp3entry.embedded_cuesheet". It also pulls the field "present" out of the "embedded_cuesheet" structure and renames it to "has_embedded_cuesheet".

This patch, together with  FS#12470 , unify how cuesheet and albumart data are represented in mp3entry.

Closed by  fml2
2011-12-22 19:00
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r31406

I like your renames. They make things more obvious and easier to understand.

To me, pulling the field out only makes sense if there's interest in shrinking mp3entry. It's possible to remove unused parts, at a cost of added code complexity and size. It's also possible to replace bools with single bit flags.

fml2 commented on 2011-12-21 19:19

I pulled out the field not becase of memory reduction, but in the first line because I find it a better style and because it brings albumart and cuesheet in line.


Available keyboard shortcuts


Task Details

Task Editing