FS#12491 - [clip v2] version is attached to the player name wich can lead to some uncoherence

Attached to Project: Rockbox
Opened by Jean-Louis Biasini (JeanLouisBiasini) - Wednesday, 28 December 2011, 20:24 GMT
Task Type Bugs
Category Manual
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.10
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


2. Installation
Installing Rockbox is generally a quick and easy procedure. However before beginning
there are a few important things to know.
2.1. Before Starting
Supported hardware versions. The Clip v2 is available in multiple versions...

this should read :"The Clip is available in multiple versions..."
This task depends upon

Comment by Frank Gevaerts (fg) - Thursday, 29 December 2011, 13:54 GMT
Maybe this is a good solution?
Comment by Jean-Louis Biasini (JeanLouisBiasini) - Thursday, 29 December 2011, 14:26 GMT
I would find instinctivily more "natural" to have a variable for the version. But in fact it all rely on how manual's guru want to organize it...
Comment by Frank Gevaerts (fg) - Thursday, 29 December 2011, 14:43 GMT
Hm, I overestimated the number of places \playertype is actually used, which is why I didn't consider a \playerversion in the first place.

Probably only the use in preamble.tex would need the version, but this would imply that either some magic is added somewhere or all platform files need a dummy \playerversion definition.

I'm not sure. On the one hand I like a localised approach that definitely only impacts the parts where there is actually a problem (generalising can introduce some bugs), but on the other hand generalising may be more maintainable later on.

I'm also not sure what you'd do with things like the clip plus. Is that a clip (version plus) , or is that a clip plus (version 1)?
Comment by Jean-Louis Biasini (JeanLouisBiasini) - Thursday, 29 December 2011, 14:51 GMT
I suppose that the point of the version is to distinguish player that would otherwise be undistinguable (i.e. same outfit)