Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by idak - 2011-12-29
Last edited by nls - 2012-03-03

FS#12494 - allow setting the hidden flag on files / folders

This patch allows setting the hidden flag on files / folders.
CAUTION! Please do not apply this patch if your DAP has imporant data.
I tested this patch, but this patch might have a bug…

All comments are welcome.

   hide.patch (20.9 KiB)
Closed by  nls
2012-03-03 11:42
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

moved to http://gerrit.rockbox.org /r/#/c/152/

Admin
fg commented on 2011-12-29 14:31

I’ve quickly looked at the patch, and I have a few comments:

* In apps/plugins/properties.c, I think it’s better to add the extra line of output in both dir_properties() and file_properties() instead of in plugin_main(). At least num_properties should be adjusted near that snprintf, instead of “adusting” later on in the call to gui_synclist_set_nb_items() (that’s asking for bugs later on).
* Does hide/unhide really need to be able to recurse? I’d assume that people will just hide or unhide the top level directory.

idak commented on 2012-02-28 16:22
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

This task was moved.
http://gerrit.rockbox.org/r/#/c/152/

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing