Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.10
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jean-Louis Biasini - 2012-01-10
Last edited by Thomas Martitz - 2012-02-08

FS#12529 - Lamp plugins PLA integration

this is a try for a PLA integration of lamp.
The purpose is to simplify manual and code keymaps

note:
- ONDAVX747(poorly) and MROBE500 added to PLA
- IAUDIO67 PLA keymaps corrected (2 command were mapped to the same keys)
- exit lamp mapped to PLA_EXIT and PLA_CANCEL

Closed by  Thomas Martitz
2012-02-08 17:09
Reason for closing:  Out of Date
Additional comments about closing:  

http://gerrit.rockbox.org/r/#chan ge,86

Jean-Louis Biasini commented on 2012-01-10 14:48

gevaerts pointed out that mr500 get handled through touchscreen interface

Thomas Martitz commented on 2012-01-11 07:48

Your changes to pluginlib_actions.c are not clear to me. Do you own the targets so you can tell it’s an improvement? Changes to PLA should probably be a separate task.

The changes to lamp look fine at first sight.

Jean-Louis Biasini commented on 2012-01-11 09:14

- ondavx747 was not impleted in PLA. Unless it’s a touchscreen device, (in which case I have to revert this part as I did for the mr500) it definitivly do no harm to have it in PLA.
- iaudio67 is a dead port, but the same key was mapped both to down and select keys. this cannot works. The only remaiming key not mapped is the one I linked as a remplacement

Thomas Martitz commented on 2012-01-11 09:21

ondavx747 is a touchscreen device. You can see such things by looking at firmware/export/config/<target>.h btw

Jean-Louis Biasini commented on 2012-01-12 18:06

ok corrected and I removed cowon2 also as it is also touchscreen

amaury pouly commented on 2012-01-15 00:41

Is this ready to commit ? I know nothing about plugin actions so I would prefer that someone review it before.

Jean-Louis Biasini commented on 2012-01-15 13:19

I guess this is ready but it would be nice to have kugel’s opinion on this

Thomas Martitz commented on 2012-01-15 13:23

It *looks* fine to me, but I haven’t tested.

Does it compile for HAVE_SCROLLWHEEL? LAMP_(UP|DOWN)_REPEAT doesn’t seem defined for those.

Jean-Louis Biasini commented on 2012-01-15 13:54

No I just tried!
Ok now this compile

Thomas Martitz commented on 2012-01-25 21:27

The block is not clear to me:

#ifdef HAVE_TOUCHSCREEN
# ifndef LAMP_LEFT
# define LAMP_LEFT PLA_LEFT
# endif
# ifndef LAMP_RIGHT
# define LAMP_RIGHT PLA_RIGHT
# endif
# ifndef LAMP_UP
# define LAMP_UP PLA_UP
# endif
# ifndef LAMP_DOWN
# define LAMP_DOWN PLA_DOWN
# endif
#endif

What’s the purpose. Isn’t touchscreen already covered by the above? (touchscreen assigns grid mode buttons for PLA so all buttons are already defined).

Otherwise it looks good. However I would prefer if you’d also upload a patch for the manual.

Jean-Louis Biasini commented on 2012-01-28 16:07

This block was also in the original part so I just translated it into PLA. I have to check if I can take it out. Ok I will add the manual patch also

Thomas Martitz commented on 2012-01-28 17:20

I see. I can be removed with the transition to PLA.

Jean-Louis Biasini commented on 2012-02-06 14:09

Touchscreen block has been taken away: (compile and works on robe500 simulatorui)
http://gerrit.rockbox.org/r/#change,86

Manual update’s patch:
http://gerrit.rockbox.org/r/#change,87

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing