- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.10
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by JeanLouisBiasini - 2012-01-10
Last edited by kugel. - 2012-02-08
Opened by JeanLouisBiasini - 2012-01-10
Last edited by kugel. - 2012-02-08
FS#12529 - Lamp plugins PLA integration
this is a try for a PLA integration of lamp.
The purpose is to simplify manual and code keymaps
note:
- ONDAVX747(poorly) and MROBE500 added to PLA
- IAUDIO67 PLA keymaps corrected (2 command were mapped to the same keys)
- exit lamp mapped to PLA_EXIT and PLA_CANCEL
Closed by kugel.
2012-02-08 17:09
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557
2012-02-08 17:09
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
gevaerts pointed out that mr500 get handled through touchscreen interface
Your changes to pluginlib_actions.c are not clear to me. Do you own the targets so you can tell it’s an improvement? Changes to PLA should probably be a separate task.
The changes to lamp look fine at first sight.
- ondavx747 was not impleted in PLA. Unless it’s a touchscreen device, (in which case I have to revert this part as I did for the mr500) it definitivly do no harm to have it in PLA.
- iaudio67 is a dead port, but the same key was mapped both to down and select keys. this cannot works. The only remaiming key not mapped is the one I linked as a remplacement
ondavx747 is a touchscreen device. You can see such things by looking at firmware/export/config/<target>.h btw
ok corrected and I removed cowon2 also as it is also touchscreen
Is this ready to commit ? I know nothing about plugin actions so I would prefer that someone review it before.
I guess this is ready but it would be nice to have kugel’s opinion on this
It *looks* fine to me, but I haven’t tested.
Does it compile for HAVE_SCROLLWHEEL? LAMP_(UP|DOWN)_REPEAT doesn’t seem defined for those.
No I just tried!
Ok now this compile
The block is not clear to me:
#ifdef HAVE_TOUCHSCREEN
# ifndef LAMP_LEFT
# define LAMP_LEFT PLA_LEFT
# endif
# ifndef LAMP_RIGHT
# define LAMP_RIGHT PLA_RIGHT
# endif
# ifndef LAMP_UP
# define LAMP_UP PLA_UP
# endif
# ifndef LAMP_DOWN
# define LAMP_DOWN PLA_DOWN
# endif
#endif
What’s the purpose. Isn’t touchscreen already covered by the above? (touchscreen assigns grid mode buttons for PLA so all buttons are already defined).
Otherwise it looks good. However I would prefer if you’d also upload a patch for the manual.
This block was also in the original part so I just translated it into PLA. I have to check if I can take it out. Ok I will add the manual patch also
I see. I can be removed with the transition to PLA.
Touchscreen block has been taken away: (compile and works on robe500 simulatorui)
http://gerrit.rockbox.org/r/#change,86
Manual update’s patch:
http://gerrit.rockbox.org/r/#change,87