• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.10
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jean-Louis Biasini - 2012-01-17
Last edited by Dominik Riebeling - 2012-01-17

FS#12542 - Rockbox Utility warning on compiling

While compiling Rockbox Utility ones get the following error:
base/system.cpp: In static member function ‘static QMap<unsigned int, QString> System::listUsbDevices()’:
base/system.cpp:249:9: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
base/system.cpp:250:13: warning: variable ‘count’ set but not used [-Wunused-but-set-variable]

count and res are just used to take the return values of libusb_init() and libusb_get_device_list but do not get used later…

the following patch let those fonction being called without saving their return value in any variable.

Closed by  Dominik Riebeling
2012-01-17 21:05
Reason for closing:  Fixed
Additional comments about closing:  

Thanks, but I've decided to check the actual values instead of ignoring them.


Available keyboard shortcuts


Task Details

Task Editing