Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Eric Lassauge - 2003-04-22
Last edited by Eric Lassauge - 2003-07-24

FS#1259 - Fade effect on next/previous song

Small patch to add fading effect (like the one done
for stop/pause) on the next/previous song actions.

Maybe it could be more general in the parameter
menu. Instead of two sub-menus ‘fade on stop/pause’ ‘fade on next/previous’ just one menu ‘fade’ with
several options: none, stop/pause, next/previous, all

Patch is unifnished: the ‘localisation’ of the menu
string is not done.

Closed by  Björn Stenberg
2003-06-05 08:41
Reason for closing:  Rejected
Additional comments about closing:  

Logged In: YES
user_id=1157

One major point of not fading on next/prev is that we want
distinct audible feedback to pressing the button.

Also, fading takes a bit of time which means the next-track
function would be slower.

Both of these problems could be fixed with a special "fade on
next/prev" setting, but I don't feel the feature is worth
spending the code (and UI real-estate) on. Sorry… :-)

Admin
Björn Stenberg commented on 2003-06-05 08:41

One major point of not fading on next/prev is that we want
distinct audible feedback to pressing the button.

Also, fading takes a bit of time which means the next-track
function would be slower.

Both of these problems could be fixed with a special "fade on
next/prev" setting, but I don't feel the feature is worth
spending the code (and UI real-estate) on. Sorry… :-)

Eric Linenberg commented on 2003-06-05 11:54

I have to disagree with Zagor here. I love the features this
patch offers. I would like to take a poll and see what % of
people use the fade on pause option.

Winamp for windows offers this behavior and it is too pleasant
to listen to – I just love it.

I think this is one that should definitly make the CVS.

Eric Lassauge commented on 2003-07-24 12:33

I still think this is an usefull patch.
BTW I don't anderstand the "special 'fade
on next/prev' setting" words from zagor :
there is allready in the patch
a configurable setting for that ! If you don't like fading
you just have to leave the default "no" value.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing