Rockbox

Tasklist

FS#1259 - Fade effect on next/previous song

Attached to Project: Rockbox
Opened by Eric Lassauge (lassauge) - Tuesday, 22 April 2003, 12:06 GMT
Last edited by Eric Lassauge (lassauge) - Thursday, 24 July 2003, 12:33 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Small patch to add fading effect (like the one done
for stop/pause) on the next/previous song actions.

Maybe it could be more general in the parameter
menu. Instead of two sub-menus 'fade on stop/pause'
'fade on next/previous' just one menu 'fade' with
several options: none, stop/pause, next/previous, all

Patch is unifnished: the 'localisation' of the menu
string is not done.
This task depends upon

Closed by  Björn Stenberg (zagor)
Thursday, 05 June 2003, 08:41 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES
user_id=1157

One major point of not fading on next/prev is that we want
distinct audible feedback to pressing the button.

Also, fading takes a bit of time which means the next-track
function would be slower.

Both of these problems could be fixed with a special "fade on
next/prev" setting, but I don't feel the feature is worth
spending the code (and UI real-estate) on. Sorry... :-)
Comment by Björn Stenberg (zagor) - Thursday, 05 June 2003, 08:41 GMT

One major point of not fading on next/prev is that we want
distinct audible feedback to pressing the button.

Also, fading takes a bit of time which means the next-track
function would be slower.

Both of these problems could be fixed with a special "fade on
next/prev" setting, but I don't feel the feature is worth
spending the code (and UI real-estate) on. Sorry... :-)
Comment by Eric Linenberg (elinenbe) - Thursday, 05 June 2003, 11:54 GMT

I have to disagree with Zagor here. I love the features this
patch offers. I would like to take a poll and see what % of
people use the fade on pause option.

Winamp for windows offers this behavior and it is too pleasant
to listen to -- I just love it.

I think this is one that should definitly make the CVS.
Comment by Eric Lassauge (lassauge) - Thursday, 24 July 2003, 12:33 GMT

I still think this is an usefull patch.
BTW I don't anderstand the "special 'fade
on next/prev' setting" words from zagor :
there is allready in the patch
a configurable setting for that ! If you don't like fading
you just have to leave the default "no" value.

Loading...