Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Rbutil git
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bluebrother - 2012-02-19
Last edited by bertrik - 2012-04-15

FS#12592 - mkimxboot calls exit() on errors

mkimxboot / imxtools use exit() in case of an error. This will cause Rockbox Utility to (unexpectedly) terminate since the OS will terminate the application, while a user will expect some response from the UI.

imxtools must not call exit(), instead it must provide the error information to the caller.

Closed by  bertrik
2012-04-15 13:46
Reason for closing:  Fixed
Additional comments about closing:  

Should be fixed now, see last comment

according to pamaury this is already fixed, should we close?

Indeed, looks like this was fixed in c483905b9244646e89bc36940da7ea5a65e37392 :

  imxtools: remove most calls to bug/bugp from core library.
  
  It should not exit() anymore on error except on malloc failure.
  Resource leaks on errors (especially I/O) are quite likely though.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing