Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Ludovic Jacques - 2012-03-04
Last edited by Jonathan Gordon - 2012-03-20

FS#12606 - UI Viewport disappears when the player skips to the next track

With the latest builds (46b34da on my YP-R0 and 9476883 on the Gigabeat UI simulator), it seems that if you are in the menus when the player skips to the next track, the UI viewport disappears for an unknown reason until you press any key (then it reappears).

For example that occurs with my 240*320 non-touch theme (you can download it in attachment)
Here is a simplified SBS from this theme to help identify the issue.

%wd
#
%?mp<%VI(Z)|%VI(X)>
%Vi(X,5,25,230,230,-)%Vf(000000)
%Vi(Z,5,25,230,-,-)%Vf(000000)
#
%xl(back_no_white,lebellium_Samsung-like3.bmp,0,0)
%xl(back_with_white,lebellium_Samsung-like.bmp,0,0)
#
%V(0,0,-,-,-)%VB %?mp<%xd(back_no_white)|%xd(back_with_white)>
#
%V(0,0,-,-,-)
#

It might be related to the new layering (%VB tag)

Closed by  Jonathan Gordon
2012-03-20 11:13
Reason for closing:  Fixed
Additional comments about closing:  

fixed in 94139ac. Annoyingly stuffed up th eorigional patch by putting half in a #if 0 :/

Ludovic Jacques commented on 2012-03-06 09:06

It seems the UI viewport also disappears when adding a song from the database into the current playlist.

Jonathan Gordon commented on 2012-03-12 09:33

Ok I have a fix for this but its really not optimal so I’m going to keep thinking about it.
The general problem is that the screens are not doing a full redraw like they should when the track updates. I guess the bigger issue is why does the UI view port get cleared when it probably doesn’t need to.

Jonathan Gordon commented on 2012-03-14 11:39

http://gerrit.rockbox.org/r/#/c/183/ is my work to fix this. It works for screens which use a list for the whole ui (i.e menu, browsers) but not for the quickscreen, pitchscreen, etc).

Jonathan Gordon commented on 2012-03-15 00:32

hmm, OK, apparently that fix broke things worse :/

Thomas Martitz commented on 2012-03-19 22:26

Would not clearing the entire display but only the viewports that belong to the skin (all except %Vi) work?

Jonathan Gordon commented on 2012-03-19 23:16

It might for for specific themes, but not as a general fix. There are a few problems with doing that:
1) the skin might not have a viewport for every pixel on the screen, so not clearing the full screen would mean some areas wont be redrawn (which might not an issue)
2) Any theme using the background layer requires a full screen viewport on the top layer of you get black areas, this needs to be cleared fully incase the background layer changes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing