FS#12608 - %pb tag draws larger area than bitmap, showing pixel garbage

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Wednesday, 07 March 2012, 22:38 GMT
Task Type Bugs
Category User Interface
Status New
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.10
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


The %pb tag has a small problem. If an image is specified but no height, the tag draws the size of a line even if larger than the the image. This leads to pixel garbage below the progressbar.

The test.wps reproduces the problem in the 320x480 sdl app The default font, 27-adobe, has to be selected probably. The wps works if a height, i.e. 20 in this case as the image height, is specified

Test.png shows the problem. is the small test theme.
This task depends upon

Comment by Jonathan Gordon (jdgordon) - Wednesday, 07 March 2012, 23:34 GMT
I'm quite tempted to call this not a bug as that is the behaviour %pb has *always* had and you should just fix it by specifiing the height.

That said it should be trivial to fix. Apps/GUI/skin_engine/skin_display.c in draw_progresssbar