Rockbox

I built a ClipZip simulator with SDL threads:

./configure –sdl-threads

When the build fails, I add firmware/asm/ffs.o to the command line that failed (make V=1)

after make install and unzip -oq -d simdisk ~/lebellium_Samsung-like_v1.30.zip :

valgrind –db-attach=yes ./rockboxui

load the lebellium theme:

==10128== Conditional jump or move depends on uninitialised value(s)
==10128== at 0x451B5F: buflibmove_callback (font.c:120)
==10128== by 0x44A305: move_block (buflib.c:217)
==10128== by 0x44A409: buflib_compact (buflib.c:294)
==10128== by 0x44A837: buflib_compact_and_shrink (buflib.c:325)
==10128== by 0x44AAAF: buflib_alloc_ex (buflib.c:515)
==10128== by 0x44AD59: core_alloc_ex (core_alloc.c:62)
==10128== by 0x42D9BB: load_skin_bmp (skin_parser.c:1696)
==10128== by 0x42DFDA: skin_data_load (skin_parser.c:1751)
==10128== by 0x42AF1E: skin_load (skin_engine.c:174)
==10128== by 0x42B078: skin_get_gwps (skin_engine.c:270)
==10128== by 0x42B138: settings_apply_skins (skin_engine.c:154)
==10128== by 0x41869F: settings_load_config (settings.c:370)

10128

10128

  at /home/fun/rockbox/firmware/font.c:120

_size = 0, _capacity = 0, _prev_char_code = 512, _prev_result = 0, _index = 0x597dfa0}

  wps_data=<optimized out>) at /home/fun/rockbox/apps/gui/skin_engine/skin_parser.c:487

  at /home/fun/rockbox/apps/gui/skin_engine/skin_parser.c:2151

params = 1892, children_count = 0, line = 20, type = TAG, params_count = 2 '\002'}

(gdb) frame
#1 0x000000000043c626 in parse_font_load (element=0x6edb10, token=0x6edb88,

  wps_data=0x77f928) at /home/fun/rockbox/apps/gui/skin_engine/skin_parser.c:487

487 ptr = strchr(filename, '.');

filename is defined on:

  char *filename = get_param_text(element, 1);

get_param_text:

static inline char*
get_param_text(struct skin_element *element, int param_number)
{

  struct skin_tag_parameter* params = SKINOFFSETTOPTR(skin_buffer, element->params);
  return SKINOFFSETTOPTR(skin_buffer, params[param_number].data.text);

}

(gdb) print 1)[1]
$75 = {type = INTEGER, data = {number = 0, text = 7318349394477056, code = 7318349394477056},

type_code = 4 '\004'}

(gdb) print 2)[1]
$76 = {type = STRING, data = {number = 1940, text = 1940, code = 1940}, type_code = 70 'F'}
(gdb) print (char*)(&buffer_start[1940])
$77 = 0x6edb78 "08-Fixed.fnt"

(gdb) print skin_buffer
$78 = 0x92d440 "(\003"
(gdb) print buffer_start
$79 = (unsigned char *) 0x6ed3e4 "\377\377\377\377\377\377\377\377"
(gdb) print buffer_front

skin_buffer and buffer_start seem to not be set to the same thing

buffer_start is in bss and skin_buffer in audiobuffer

Allocation is made here:

(gdb) frame 3
#3 0x0000000000486807 in skin_parse_tag (element=0x6edb10, document=0x7fefff7c0)

  at /home/fun/rockbox/lib/skin_parser/skin_parser.c:812

812 if (callback(element, callback_data) == CALLBACK_ERROR)
(gdb) print params[1]
$4 = {type = STRING, data = {number = 1940, text = 1940, code = 1940}, type_code = 70 'F'}

line 801: element→params = skin_buffer_to_offset(params);
skin_buffer_to_offset() references buffer_start, which was set to skin_buffer by skin_buffer_init()

When params is used in parse_font_load(), skin_buffer has changed.

This patch is needed to build the sim with –sdl-threads

–sdl-threads is MANDATORY for valgrind

   build-sim.diff (0.6 KiB)

lib/skin_parser/skin_parser.c:801 element→params = skin_buffer_to_offset(params);

skin_buffer_to_offset() use buffer_start relative offset (buffer_start is internal to lib/skin_parser)

apps/gui/skin_engines/skin_parser.c:397 filename = get_param_text(element, 1);

get_param_text() use SKINOFFSETPTR(skin_buffer, elements→param), skin_buffer is internal to apps/gui/skin_engine

The 2 buffers (internal to each folder) are unsynchronized → boom we are now reading random memory

http://gerrit.rockbox.org/r/#/c/235

I have a similar problem but just that the theme is breaking the USB.

http://www.rockbox.org/tracker/task/12813?project=1&type=2&order=dateopened&sort=desc

Woops, posted the wrong link.

http://www.rockbox.org/tracker/task/12813

Bug report that I filed in the other task:

I've tried Ignus and Rayborraido_ypr0 and both fail to connect to USB. I always get memory error. The only theme that I can use to connect to USB is Cabbie.

I'm currently using the latest build from the 27th of January 2013.

This is the error I get on the screen with Ignus theme applied:

data abort at 6002DE30.
FSR 0x1 (Domain 0, Fault 1)
address: 0x602026CDA
pc: 6002DE30 sp: 600AC9D0
A: 6002A030
A: 60027E88
A: 60028AE4
A: 6004A850
A: 600009F0
A: 60000DB4
A: 60043EFC
A: 60044254
bt end

Tested fuze+ sim with RAYBORADIO (you made the same typo 2 times)

configured with –sdl-threads

Pressing u 2 times (plug, then unplug)

USB inserted. Waiting for 6 acks… usb: got ack, 5 to go… usb: got ack, 4 to go… usb: got ack, 3 to go… usb: got ack, 2 to go… usb: got ack, 1 to go… All threads have acknowledged the connect.
usb: got ack, 0 to go… ==26664== Thread 1:
==26664== Conditional jump or move depends on uninitialised value(s)
==26664== at 0x45413C: buflibmove_callback (font.c:113)
==26664== by 0x44C686: move_block (buflib.c:225)
==26664== by 0x44C88F: buflib_compact (buflib.c:307)
==26664== by 0x44CCF2: buflib_compact_and_shrink (buflib.c:338)
==26664== by 0x44CF74: buflib_alloc_ex (buflib.c:528)
==26664== by 0x44D1DD: core_alloc (core_alloc.c:57)
==26664== by 0x42FE14: skin_data_load (skin_parser.c:2422)
==26664== by 0x42C8DD: skin_load (skin_engine.c:176)
==26664== by 0x42CA43: skin_get_gwps (skin_engine.c:274)
==26664== by 0x42CB0B: settings_apply_skins (skin_engine.c:156)
==26664== by 0x445914: gui_usb_screen_run (usb_screen.c:333)
==26664== by 0x40D9B5: default_event_handler_ex (misc.c:556)

26664

26664

I can confirm this bug.

I've been having USB problems with my Clip+, I would do a basic transfer (File-heavy) and after a while the device would simply freeze. USB devices shown on my computer were completely empty.

After switching to a failsafe theme of rockbox, not only did windows detect my device a whole lot faster, but I somehow gained 2MB/s of xfer rate.

I was told on IRC to report my findings, and these are it.

P.S: After 3 transfers, it seems to still be working fine! :O