FS#12647 - Improved support for ALBUMARTIST

Attached to Project: Rockbox
Opened by Jean Tourrilhes (jean2) - Saturday, 14 April 2012, 05:44 GMT
Last edited by Thomas Martitz (kugel.) - Tuesday, 17 April 2012, 06:24 GMT
Task Type Bugs
Category Database
Status Closed
Assigned To No-one
Operating System Sansa AMSv2
Severity Low
Priority Normal
Reported Version Release 3.11
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No



I'm using the tag "ALBUM ARTIST" on my Vorbis files, and I'm not completely happy with the current support for the tag in RockBox.

The main problem is that the database menu for "ALBUM ARTIST" contains a subset of my artists, only those in an "ALBUM ARTIST" tag, and any album that don't have an "ALBUM ARTIST" tag can't be reached via this menu. At first glance, it would seem correct, but this does not follow the spirit of the standard.

Here is how the tag should be used :
tag should only exist if an album contains various artists. It should NOT be created when an album does not contain various artists.

I have a mix of compilations and non-compilation albums. Using Foobar, Amarok or the SqueezeBox, when I want to play an album, I select it by Album Artist. On those system, it works great, I can see all my albums through that menu. In those systems, every album which does not have an Album Artist, the Album Artist in the database is automatically populated from the Artist field.

RockBox is the odd one out, not behaving like the rest. It would be nice to fix that behaviour and make the Album Artist functionality really useful.

While we are on the topic...

Mp3tag and Foobar are slowly migrating from "ALBUM ARTIST" to "ALBUMARTIST".
I have not checked if RockBox support that variation of the tag...

Support for ARTISTSORT and ALBUMARTISTSORT would also be appreciated. One can always dream, I guess...

Have fun...

This task depends upon

Closed by  Thomas Martitz (kugel.)
Tuesday, 17 April 2012, 06:24 GMT
Reason for closing:  Works For Me
Additional comments about closing:  As requested by the OP.
Comment by Jean Tourrilhes (jean2) - Saturday, 14 April 2012, 05:48 GMT
Forgot to mention that all my files are Vorbis.
Comment by Thomas Martitz (kugel.) - Sunday, 15 April 2012, 11:17 GMT
I agree, the fallback to ARTIST should be taken instead of forcing ALBUMARTIST on all albums. With the same mechanism *SORT could be supported efficiently. BTW, there is a task about it: FS#7287. The implementation there is not very efficient because there is no fallback
Comment by Jean Tourrilhes (jean2) - Monday, 16 April 2012, 05:44 GMT
Thomas Martitz wrote :
> the fallback to ARTIST should be taken instead of forcing ALBUMARTIST on all albums.

In my opinion, I would assume it's more efficient to apply the falback when populating the database rather than when reading the database, as the fallback can be kept in a single place and population happens less often and is not on the critical path. That would seem to me a fair tradeoff to the marginal increase in size of the database. But, of course, I never peek under the hood of RockBox, so I maybe totally wrong.
Comment by Thomas Martitz (kugel.) - Monday, 16 April 2012, 06:10 GMT
The increase is not marginal. Each DB index file (which contains either album, artist or title, etc) can be several 100k big.
Comment by Jean Tourrilhes (jean2) - Tuesday, 17 April 2012, 04:19 GMT
I just upgraded to 3.11 (from 3.09), and it look to me as if Album Artist is working properly. A first glance, all my files that don't have an ALBUM ARTIST tag are properly listed in the database under Album Artist.
So, either something changed from 3.09 to 3.11, or I was doing something wrong previously.
Anyway, it works, time to close this bug.