Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System Sansa AMSv2
  • Severity Low
  • Priority Very Low
  • Reported Version Rbutil git
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasferret - 2012-05-25
Last edited by saratoga - 2012-05-25

FS#12685 - disk access on volume change

At least with the newest build 652b39b volume changes on my sansa clip+ are awfully slow. I think its because every volume change triggers a disk access.

Closed by  saratoga
2012-05-25 22:14
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in 3f72ba0.

8689bcc-120525 breaks this.

As for why this happens on volume, I'm baffled as to why volume changes even trigger a storage callback.

Admin
fg commented on 2012-05-25 22:14

This should be fixed in 3f72ba0. Can someone verify?

Volume changes are saved to the config file. If storage callbacks are enabled, this will happen the next time storage is used for other reasons (so disks don't spin up too often, or flash doesn't power on too often). Otherwise, the save is synchronous (and therefore slow).

6b8330d2, which was meant to add enabling storage callbacks for hosted targets (i.e. sims and application builds), was wrong and instead basically enabled it *only* for hosted targets, dropping the native targets.

Apparently that commit caused the config file to be rewritten on every volume change. Its fixed.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing