FS#12706 - cabbiev2.cfg is generated with invalid paths

Attached to Project: Rockbox
Opened by Hayden Pearce (St.) - Monday, 25 June 2012, 04:21 GMT
Last edited by Thomas Martitz (kugel.) - Monday, 25 June 2012, 06:55 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Daily build (which?): git HEAD

It is my understanding that the recent changes to (Idf5994f17b9750983d7bc3ef583540a8cdae1dde wpsbuild: Rewrite to fix various issues and support .fms) have caused an error with the default theme.

As the description states, the cabbiev2 .cfg is being generated with bogus paths, specifically for backdrop, icons, and viewer icons:

# cabbiev2.cfg generated by
# cabbiev2.320x240x16.wps is made by Johannes Voggenthaler, Apoo Maha, Marc Guay, Alex Vanderpol, Jerry Lange, Keith Perri, Mark Fawcus, and Marianne Arnold with support from Rockbox developers and forums. Based on Cabbie by Yohann Misquitta.
wps: /.rockbox/wps/cabbiev2.wps
sbs: -
selector type: bar (gradient)
backdrop: backdrops/cabbiev2.bmp
filetype colours: -
foreground color: CCCCCC
background color: 000000
line selector start color: fde89e
line selector end color: b58c00
line selector text color: 000000
font: /.rockbox/fonts/15-Adobe-Helvetica.fnt
statusbar: top
iconset: icons/tango_icons.16x16.bmp
viewers iconset: icons/tango_icons_viewers.16x16.bmp
ui viewport: -

I was made aware of the cabbiev2 backdrop failing to be applied in the sim approximately a week ago by bertrik (iirc), and thought little of it at the time. Though I should have.
I didn't check up on it, and I guess the missing icon(s) weren't noticed by him at the time either(?).

I have had a brief look, and I have gathered some understanding of, but so far my poking at it has simply angered the beast even more.

So, I pass this on to someone else more capable (and with more time) than I.

This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 25 June 2012, 06:55 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in bc7ff53. Thank you