FS#12720 : Lrcplayer opens and plays USLT tag instead of SYLT tag

Quick Actions

View Dependency Graph

Status Unconfirmed
Percent Complete
0%
Task Type Bugs
Category Plugins
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Release 3.11
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by Vlamik - 2012-07-26

FS#12720 - Lrcplayer opens and plays USLT tag instead of SYLT tag - Sansa Clip+

I have sansa clip+. Lrcplayer opens and plays USLT tag instead of SYLT tag if there are both in mp3 file and no external lyrics(.lrc, .lrc8, .snc, .txt) so lyrics which play are not synchronized. Please make SYLT tag opens and plays defaultly instead of USLT tag.

Comments (8)
Related Tasks (0/0)

bertrik commented on 2012-07-26 11:19

As I understand, the SYLT is more useful than the USLT tag, because it's time-synchronised, right?
I have no experience at all with lyrics parsing.

Would it be possible for you to create a source code patch yourself and submit it to gerrit?
If not, can you provide with an example file where the problem occurs?

Vlamik commented on 2012-07-26 12:44

Problem occurs in every mp3 file with both SYLT and USLT tag.
I'm not a developer so I can at least provide you example file where the problem occurs.
https://www.dropbox.com/s/znqsuaia6d14k4q/01%20Get%20The%20Party%20Started.mp3 I'm Slovak so sorry for my English.

Vlamik commented on 2012-07-26 15:05

Sorry for bad file. It's repaired.

bertrik commented on 2012-07-26 18:05

Warning: Undefined array key "mailguard" in /home/rockbox/flyspray/plugins/dokuwiki/inc/common.php on line 929 Warning: Undefined array key "mailguard" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 697

The problem seems to be that the file contains both types, with the USLT tag first, which is selected for being the first we see.
A fix would be to detect both and remember where we found the tags, then decide which one gets precedence.
Teruaki Kawashima teru@rockbox.org appears to be the expert on this particular plugin.

teru commented on 2012-07-28 09:56

bertik is right.
problem is the first USLT/SYLT tag is used.
fix would be remember position of USLT and use the USLT if the file doesn't contain SYLT.
i don't mind fixing this, but please don't expect it will be soon as it's been long since i last used rockbox.

teru commented on 2012-09-04 12:41

this patch fix the issue.

lrcplayer.patch (5.3 KiB)

bertrik commented on 2012-09-08 10:08

Vladimir, can you test and confirm that it fixes the issue for you?

Vlamik commented on 2012-09-08 10:46

Sorry, I don't know how to patch it.