Rockbox

Tasklist

FS#12720 - Lrcplayer opens and plays USLT tag instead of SYLT tag - Sansa Clip+

Attached to Project: Rockbox
Opened by Vladimír Mikuláš (Vlamik) - Thursday, 26 July 2012, 09:51 GMT
Task Type Bugs
Category Plugins
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.11
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I have sansa clip+. Lrcplayer opens and plays USLT tag instead of SYLT tag if there are both in mp3 file and no external lyrics(.lrc, .lrc8, .snc, .txt) so lyrics which play are not synchronized. Please make SYLT tag opens and plays defaultly instead of USLT tag.
This task depends upon

Comment by Bertrik Sikken (bertrik) - Thursday, 26 July 2012, 11:19 GMT
As I understand, the SYLT is more useful than the USLT tag, because it's time-synchronised, right?
I have no experience at all with lyrics parsing.

Would it be possible for you to create a source code patch yourself and submit it to gerrit?
If not, can you provide with an example file where the problem occurs?
Comment by Vladimír Mikuláš (Vlamik) - Thursday, 26 July 2012, 12:44 GMT
Problem occurs in every mp3 file with both SYLT and USLT tag.
I'm not a developer so I can at least provide you example file where the problem occurs.
https://www.dropbox.com/s/znqsuaia6d14k4q/01%20Get%20The%20Party%20Started.mp3
I'm Slovak so sorry for my English.
Comment by Vladimír Mikuláš (Vlamik) - Thursday, 26 July 2012, 15:05 GMT
Sorry for bad file. It's repaired.
Comment by Bertrik Sikken (bertrik) - Thursday, 26 July 2012, 18:05 GMT
The problem seems to be that the file contains both types, with the USLT tag first, which is selected for being the first we see.
A fix would be to detect both and remember where we found the tags, then decide which one gets precedence.
Teruaki Kawashima <teru@rockbox.org> appears to be the expert on this particular plugin.
Comment by Teruaki Kawashima (teru) - Saturday, 28 July 2012, 09:56 GMT
bertik is right.
problem is the first USLT/SYLT tag is used.
fix would be remember position of USLT and use the USLT if the file doesn't contain SYLT.
i don't mind fixing this, but please don't expect it will be soon as it's been long since i last used rockbox.
Comment by Teruaki Kawashima (teru) - Tuesday, 04 September 2012, 12:41 GMT
this patch fix the issue.
Comment by Bertrik Sikken (bertrik) - Saturday, 08 September 2012, 10:08 GMT
Vladimir, can you test and confirm that it fixes the issue for you?
Comment by Vladimír Mikuláš (Vlamik) - Saturday, 08 September 2012, 10:46 GMT
Sorry, I don't know how to patch it.

Loading...