Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.11
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Riffer - 2012-11-08
Last edited by bluebrother - 2012-11-09

FS#12779 - This patch reworks the sleep timer a little bit and fixes a small bug.

After seeing that nearly all what I wanted to have regarding the sleep timer I had only one point left: The sleep timer should not shut down but instead turn into pause playing. After this the standard poweroff timer gets to work. If the poweroff timer is not set the sleep timer directly shuts down as before.

This fixes a bug too - there was a pause on sleep timer end but only for the situation where usb (I think mostly for battery purpose?) is connected. But after that the sleep timer won’t be restarted on button use! This has been fixed now.

Closed by  bluebrother
2012-11-09 20:17
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

Patch is now on gerrit: http://gerrit.rockbox.org /r/#/c/349/

Riffer commented on 2012-11-08 21:41

here the patch itself

   sleeptimer.patch (1.7 KiB)
bluebrother commented on 2012-11-08 22:05

We prefer patches on gerrit these days. Is it possible for you to push it there?

Riffer commented on 2012-11-09 19:17
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

After having a good time with gerrit (maybe the instructions should say very clearly that the Username is case sensitive?) its done:

http://gerrit.rockbox.org/r/#/c/349/

Riffer commented on 2012-11-09 20:13

(forget about the case sensitive, I just added it - nice to be part of the team!)

Someone could lease close this. Many thanks!

Riffer commented on 2012-11-09 20:14

*please

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing