Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Sahand_N - 2013-01-25
Last edited by jdgordon - 2013-02-04

FS#12811 - Problem with %Cl tag

I’m using a Sansa Clip Zip,
Starting from build 9b7edbf (2013-01-16), Rockbox completely ignores maxwidth and maxheight specified within %Cl tag.
The attached screenshots are from 9b7edbf and d24c220 (2013-01-15) using exactly the same theme.
And the tag I used is: %Cl(0,0,96,96,c,c).

Closed by  jdgordon
2013-02-04 08:35
Reason for closing:  Not a Bug
Sahand_N commented on 2013-01-25 10:54

oops!

   9b7edbf.bmp (18.1 KiB)
   d24c220.bmp (18.1 KiB)
jdgordon commented on 2013-02-03 02:18

I need to see the whole wps to understand the issue… is 96×96 bigger or smaller than the viewport it is in?

jdgordon commented on 2013-02-03 02:38
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

talking in IRC, it seems like the current behaviour is actually correct and the old behaviour was wrong. http://www.rockbox.org/irc/log-20130203#03:17:14

Sahand_N commented on 2013-02-04 08:28
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

You’re right, I forgot to mention it. This is the viewport:
%Vl(a,0,10,96,74,-)
%Cl(0,0,96,96,c,c)
%Cd
Starting from build 9b7edbf, Rockbox loads the AA 74px high and 74px wide because of the dimension specified within %Vl (or %V), rendering maxwidth and maxheight of the %Cl tag completely useless.
It also changes the way some themes like http://themes.rockbox.org/index.php?themeid=1524&target=sansaclipzip look.
I know it’s silly to display AA on such a small screen and I don’t want to that, but some themes on bigger players might be affected.

jdgordon commented on 2013-02-04 08:35

ok, so yeah, this is actually the correct behaviour and your theme is broken :) change the viewport to be 96×96 if that is what you want.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing