Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Drivers
  • Assigned To
    Bertrik Sikken
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.12
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sergio - 2013-04-15
Last edited by Bertrik Sikken - 2013-05-17

FS#12854 - ipod-time-sync sets wrong day

Time sync works wrong for my sansa clipzip. It sets correct local time (hours, minutes, and seconds), correct year, and month, but wrong day. Today is 15 April but player shows 18 after synchronization.

I checked this with ipod-time-sync from libgpod-common 0.8.2-7 from debian sid and time-sync from trunk.

Closed by  Bertrik Sikken
2013-05-17 19:16
Reason for closing:  Fixed
Additional comments about closing:  

Tested and applied Boris' fix

asdsdaw commented on 2013-05-02 15:00

I’m also having this problem on my iPod classic 160 gb with version 354c989-130424. After every sync with my PC it jumps forward a few days. I wouldn’t care if it wasn’t for the fact that my last.fm logs get all messed up, but now they do, so it’s kind of annoying to always have to remember to set the date manually before you start listening.

Boris Gjenero commented on 2013-05-15 15:49

This is because in yearday_to_daymonth(), the array of month lengths starts at 0, and the leap year determining code writes to index 2, giving March the length intended for February. Here’s a fix.

sergio commented on 2013-05-17 09:16

Thank you, Boris.
I’d be happy to test it, but unfortunately I don’t have time to rebuild.
Could you build it or say when this patch will be included in trunk so I can try daily build.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing