Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.12
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jwhitham - 2013-07-09
Last edited by kugel. - 2013-12-23

FS#12878 - Zero-length embedded album art prevents mp3 playback

MP3 files with id3v2 APIC tags containing 0 bytes of “image/jpeg” data will not be played by Rockbox - both version 3.13 and the current GIT version.

The attached zip file contains an mp3 with a malformed tag. I zeroed all the data after the first 128kb, this is a store-bought file, the store was responsible for the malformed id3v2 tag. The mp3 file will play in all the other decoders that I tested - WMP, foobar, mpg123, mplayer.

Using rockbox, the zero size image data triggers erroneous behaviour in the bufopen function (buffering.c) where the following code is executed: “if (size == 0) size = filesize(fd);” This causes bufopen to print the error “bufopen(): failed to add handle”. It returns ERR_BUFFER_FULL. Playback is prevented.

I’m also attaching a patch which fixes the issue. Tested in the UI simulator.

   malformed_apic_bug_demo.zip (122.1 KiB)
   malformed_apic_bug_demo.patch (0.7 KiB)
Closed by  kugel.
2013-12-23 16:55
Reason for closing:  Fixed
Additional comments about closing:  

ca423ed0e317645c8febb8dc604743f0fd47139a

kugel. commented on 2013-07-10 09:15

Thank you. The fix seems like a nobrainer. However we accept patches through gerrit these days. Can you upload it there (gerrit.rockbox.org)?

jwhitham commented on 2013-07-11 00:13

The process for using that site looks a bit complex and I don’t think I have time to learn how to do it properly. Maybe you would be willing to upload this small patch on my behalf? Thanks in advance.

btw. I have now successfully tested it on my Sansa Clip Zip.

kugel. commented on 2013-07-11 18:28

http://www.rockbox.org/wiki/UsingGit has a quick start guide for gerrit. If you still cannot use it can you provide a ‘git format-patch’ with commit message?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing