FS#12878 - Zero-length embedded album art prevents mp3 playback
Opened by Jack Whitham (jwhitham) - Tuesday, 09 July 2013, 21:12 GMT
Last edited by Thomas Martitz (kugel.) - Monday, 23 December 2013, 16:55 GMT
|
DetailsMP3 files with id3v2 APIC tags containing 0 bytes of "image/jpeg" data will not be played by Rockbox - both version 3.13 and the current GIT version.
The attached zip file contains an mp3 with a malformed tag. I zeroed all the data after the first 128kb, this is a store-bought file, the store was responsible for the malformed id3v2 tag. The mp3 file will play in all the other decoders that I tested - WMP, foobar, mpg123, mplayer. Using rockbox, the zero size image data triggers erroneous behaviour in the bufopen function (buffering.c) where the following code is executed: "if (size == 0) size = filesize(fd);" This causes bufopen to print the error "bufopen(): failed to add handle". It returns ERR_BUFFER_FULL. Playback is prevented. I'm also attaching a patch which fixes the issue. Tested in the UI simulator. |
Monday, 23 December 2013, 16:55 GMT
Reason for closing: Fixed
Additional comments about closing: ca423ed0e317645c8febb8dc604743f0fd47139a
btw. I have now successfully tested it on my Sansa Clip Zip.