FS#12887 - Fix for wrong playlist order after moving tracks before current
When moving a track within a playlist to any position before the currently playing track, the index of the currently playing track on the playlist gets shifted back by 1. This causes two problems:
-The playlist shows a wrong track as the current track being played
-The currently playing track is played once more when finished
The only exception is when moving to the first position in the playlist, since that is handled as a prepend and works as expected.
AFAIK this issue affects all players and has been present at least since 3.6 (see #FS11376 http://www.rockbox.org/tracker/task/11376)
Attached is a patch against 49bcf35 that (hopefully) fixes this issue by comparing the display indexes of the positions we’re moving from/to and the currently playing track, incrementing the playlist index when neccessary.
playlist_move_fix.diff
(3.3 KiB)
2019-07-24 18:25
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Better late than never, this has finally
been committed as 7bef453e.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Moving this to gerrit: http://gerrit.rockbox.org/r/#/c/530/