Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#12951 : Menu icons one pixel too down now

Rockbox

Tasklist

FS#12951 - Menu icons one pixel too down now

Attached to Project: Rockbox
Opened by Ludovic Jacques (lebellium) - Saturday, 15 February 2014, 21:07 GMT
Last edited by Thomas Martitz (kugel.) - Monday, 03 March 2014, 10:21 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System Sansa Clip Zip
Severity Medium
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

It occurs on my Clip Zip. I didn't try on other targets though. You can compare the 2 screenshots in attachment.

After bisecting, the 1st bad commit is eec89a9 by kugel: lists: Adapt put_line() ( http://git.rockbox.org/?p=rockbox.git;a=commit;h=eec89a9 )

   git bisect BAD.bmp (18.1 KiB)
   git bisect GOOD.bmp (18.1 KiB)
This task depends upon

Closed by  Thomas Martitz (kugel.)
Monday, 03 March 2014, 10:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  3ae07d4
Comment by Thomas Martitz (kugel.) - Friday, 28 February 2014, 07:01 GMT
Does this fix the issue?
   0001-Fix-FS-12951-The-icons-c... (1.5 KiB)
Comment by Ludovic Jacques (lebellium) - Friday, 28 February 2014, 20:55 GMT
Yes, with my theme it's perfect now, as before. I didn't check if there are consequences for cabbiev2 and other themes though.

Loading...