Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 FS#12951 : Menu icons one pixel too down now

Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System Sansa Clip Zip
  • Severity Medium
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lebellium - 2014-02-15
Last edited by kugel. - 2014-03-03

FS#12951 - Menu icons one pixel too down now

It occurs on my Clip Zip. I didn’t try on other targets though. You can compare the 2 screenshots in attachment.

After bisecting, the 1st bad commit is eec89a9 by kugel: lists: Adapt put_line() ( http://git.rockbox.org/?p=rockbox.git;a=commit;h=eec89a9 )

   git bisect BAD.bmp (18.1 KiB)
   git bisect GOOD.bmp (18.1 KiB)
Closed by  kugel.
2014-03-03 10:21
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

3ae07d4

kugel. commented on 2014-02-28 07:01

Does this fix the issue?

   0001-Fix-FS-12951-The-icons-c... (1.5 KiB)
lebellium commented on 2014-02-28 20:55

Yes, with my theme it’s perfect now, as before. I didn’t check if there are consequences for cabbiev2 and other themes though.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing