Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#12995 : path_trim_whitespace() assumes unsigned char

Rockbox

Tasklist

FS#12995 - path_trim_whitespace() assumes unsigned char

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Monday, 15 September 2014, 22:32 GMT
Last edited by Michael Sevakis (MikeS) - Tuesday, 16 September 2014, 03:15 GMT
Task Type Bugs
Category Playlists
Status Closed
Assigned To Michael Sevakis (MikeS)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

path_trim_whitespace() (introduced in 7d1a47cf) assumes unsigned char (things like c <= ' '). This makes it break on some platforms (including the simulator on x86/amd64). I don't know if that commit has other similar issues.
This task depends upon

Closed by  Michael Sevakis (MikeS)
Tuesday, 16 September 2014, 03:15 GMT
Reason for closing:  Fixed
Additional comments about closing:  Should be ok as of c1bbaf4
Comment by Michael Sevakis (MikeS) - Monday, 15 September 2014, 23:06 GMT
Aright, tell me what's going on. I had no problems with the sim myself or nothing happened that indicated one.
Comment by Michael Sevakis (MikeS) - Monday, 15 September 2014, 23:18 GMT
Aha, hmm...no, I didn't assume unsigned char, I just did it wrong where anything >= 0x7f gets sign extended as a negative value! Derp. :)

There aren't any other comparisons like that. The closest thing is path_strip_drive which compares for 'A' to 'Z'.

Loading...