- Status Closed
- Percent Complete
- Task Type Bugs
- Category Playlists
-
Assigned To
MikeS - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12995 - path_trim_whitespace() assumes unsigned char
path_trim_whitespace() (introduced in 7d1a47cf) assumes unsigned char (things like c ⇐ ' ‘). This makes it break on some platforms (including the simulator on x86/amd64). I don’t know if that commit has other similar issues.
Closed by MikeS
2014-09-16 03:15
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2014-09-16 03:15
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Should be ok as of c1bbaf4
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Aright, tell me what’s going on. I had no problems with the sim myself or nothing happened that indicated one.
Aha, hmm…no, I didn’t assume unsigned char, I just did it wrong where anything >= 0x7f gets sign extended as a negative value! Derp. :)
There aren’t any other comparisons like that. The closest thing is path_strip_drive which compares for ‘A’ to ‘Z’.