• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Playlists
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fg - 2014-09-15
Last edited by MikeS - 2014-09-16

FS#12995 - path_trim_whitespace() assumes unsigned char

path_trim_whitespace() (introduced in 7d1a47cf) assumes unsigned char (things like c ⇐ ' ‘). This makes it break on some platforms (including the simulator on x86/amd64). I don’t know if that commit has other similar issues.

Closed by  MikeS
2014-09-16 03:15
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Should be ok as of c1bbaf4

MikeS commented on 2014-09-15 23:06

Aright, tell me what’s going on. I had no problems with the sim myself or nothing happened that indicated one.

MikeS commented on 2014-09-15 23:18

Aha, hmm…no, I didn’t assume unsigned char, I just did it wrong where anything >= 0x7f gets sign extended as a negative value! Derp. :)

There aren’t any other comparisons like that. The closest thing is path_strip_drive which compares for ‘A’ to ‘Z’.


Available keyboard shortcuts


Task Details

Task Editing