- Status Closed
- Percent Complete
- Task Type Bugs
- Category Playlists
-
Assigned To
MikeS - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12996 - path_trim_whitespace() shouldn't trim the start of a filename
Filenames can legally start with space characters. This was supported before 7d1a47cf. The new path_trim_whitespace() trims both the start and end of filenames.
Closed by MikeS
2017-10-18 20:06
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2017-10-18 20:06
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Function was removed anyway and old
behavior restored in 5c6ccb4.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
I know they can but does this even make sense. Is playlist parsing supposed to include leading whitespace? That’s the only code using it for now but other stuff can be put together to support alternatives. What about quoted paths?
VLC does eat the whitespace at the start and end of the line while WMP only eats the trailing ones. Does “legally” refer to M3U specifically (not legal FS paths in particular)?
path_trim_whitespace() isn’t only called for m3u files. It’s called for any file you try to add to the playlist, a.k.a. any file you try to play.
I’m considering something else that only trims, changes separators or strips drive letters for parsing a cuesheet but makes no modification to paths given from internal sources like the file browser.