• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Playlists
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fg - 2014-09-15
Last edited by MikeS - 2017-10-18

FS#12996 - path_trim_whitespace() shouldn't trim the start of a filename

Filenames can legally start with space characters. This was supported before 7d1a47cf. The new path_trim_whitespace() trims both the start and end of filenames.

Closed by  MikeS
2017-10-18 20:06
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Function was removed anyway and old behavior restored in 5c6ccb4.

MikeS commented on 2014-09-15 23:40

I know they can but does this even make sense. Is playlist parsing supposed to include leading whitespace? That’s the only code using it for now but other stuff can be put together to support alternatives. What about quoted paths?

MikeS commented on 2014-09-16 03:24

VLC does eat the whitespace at the start and end of the line while WMP only eats the trailing ones. Does “legally” refer to M3U specifically (not legal FS paths in particular)?

fg commented on 2014-09-16 08:34

path_trim_whitespace() isn’t only called for m3u files. It’s called for any file you try to add to the playlist, a.k.a. any file you try to play.

MikeS commented on 2014-09-17 06:26

I’m considering something else that only trims, changes separators or strips drive letters for parsing a cuesheet but makes no modification to paths given from internal sources like the file browser.


Available keyboard shortcuts


Task Details

Task Editing