Rockbox

Tasklist

FS#13007 - FM Region "Other": Enable full frequency range.

Attached to Project: Rockbox
Opened by Oid Maps (oid_maps) - Monday, 29 September 2014, 09:26 GMT
Task Type Patches
Category FM Tuner
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch changes the frequency range when selecting "Region: Other" for the FM radio:

With this patch, the "full range" from 76 MHz to 108 MHz, in 0.05 MHz steps, is available when selecting the "Other" region.
This task depends upon

Comment by Bertrik Sikken (bertrik) - Monday, 29 September 2014, 15:40 GMT
76 MHz is a bit arbitrary, probably not all tuner ICs support this. You could as well argue that it should be 65 MHz.
Possibly the best solution is to make it dynamic somehow, like letting the tuner driver expose the range that it supports.
Comment by Oid Maps (oid_maps) - Monday, 29 September 2014, 16:50 GMT
Yes, an option max hardware supported range would be great (also with the granularity of the frequency steps -- by the way, manual entry of the MHz as a number would be great).
But 76 MHz is just what also the "Japanese" setting gives, so if the "Japanese" setting is assumed to be sane, 76 MHz - 108 MHz is as well assumed to be sane ...
Comment by Oid Maps (oid_maps) - Monday, 29 September 2014, 19:57 GMT
Bertrik Sikken (bertrik) wrote:
> 76 MHz is a bit arbitrary, probably not all tuner ICs support this.
> You could as well argue that it should be 65 MHz.

If we cannot read it out from hardware, then maybe there can be a list specific to each player we can build for?
Comment by Michael Sevakis (MikeS) - Thursday, 02 October 2014, 20:13 GMT
Add a new driver message that takes a struct fm_region_data and fills it in with the capabilities. Use that thereafter.

ETA: If the tuner interface needs some tweaking, I guess go ahead; it's a bit primitive anyway. I didn't want have a ton of different message to query specific things since that's far more messy imo.

Loading...