Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Configuration
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by albertogorjon - 2016-04-25
Last edited by speachy - 2020-06-15

FS#13073 - Samsung YP-R0, bug, Colour Configuration

Samsung YP-R0

Error keyboard mapping of menu: Settings - Theme Settings - Colours - Foreground Colour /Background Colour, don’t allow change colors

Closed by  speachy
2020-06-15 15:56
Reason for closing:  Fixed

I confirm the issue.

I checked a bit how was the keymapping on other targets like H320 or Fuze+ and adapt it to R0. I can’t say I really understood what I did exactly but I confirm it works properly now.
I can’t write a proper patch myself so if someone is willing to do it and push it, that would be nice :)

In keymap-ypr0.c
I replaced:

static const struct button_mapping button_context_settings[] = {

  { ACTION_SETTINGS_INC,       BUTTON_RIGHT,                  BUTTON_NONE },
  { ACTION_SETTINGS_INCREPEAT, BUTTON_RIGHT|BUTTON_REPEAT,    BUTTON_NONE },
  { ACTION_SETTINGS_DEC,       BUTTON_LEFT,                   BUTTON_NONE },
  { ACTION_SETTINGS_DECREPEAT, BUTTON_LEFT|BUTTON_REPEAT,     BUTTON_NONE },
  LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_TREE)

}; /* button_context_settings */

By:
static const struct button_mapping button_context_settings[] = {

  { ACTION_SETTINGS_INC,       BUTTON_UP,                     BUTTON_NONE },
  { ACTION_SETTINGS_INCREPEAT, BUTTON_UP|BUTTON_REPEAT,       BUTTON_NONE },
  { ACTION_SETTINGS_DEC,       BUTTON_DOWN,                   BUTTON_NONE },
  { ACTION_SETTINGS_DECREPEAT, BUTTON_DOWN|BUTTON_REPEAT,     BUTTON_NONE },
  LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_TREE)

}; /* button_context_settings */

static const struct button_mapping button_context_settings_right_is_inc[] = {

  { ACTION_SETTINGS_INC,       BUTTON_RIGHT,                  BUTTON_NONE },
  { ACTION_SETTINGS_INCREPEAT, BUTTON_RIGHT|BUTTON_REPEAT,    BUTTON_NONE },
  { ACTION_SETTINGS_DEC,       BUTTON_LEFT,                   BUTTON_NONE },
  { ACTION_SETTINGS_DECREPEAT, BUTTON_LEFT|BUTTON_REPEAT,     BUTTON_NONE },
  LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_STD)

}; /* button_context_settingsgraphical */

case CONTEXT_CUSTOM|CONTEXT_SETTINGS:

  case CONTEXT_SETTINGS_RECTRIGGER:
          return button_context_settings_right_is_inc;

I tested the behavior and I cannot reproduce the issue anymore.
This is justified by the commit at https://git.rockbox.org/?p=rockbox.git;a=commit;h=108a0f3 Therefore, it could be closed.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing