• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version Release 3.14
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fip - 2018-04-01
Last edited by speachy - 2020-08-24

FS#13154 - rc error code discarded in storage_init

I think commit 1654efc31339972d0e6bd41a499fcffc0a45822e introduces the following error:
storage_init in firmware/storage.c does not return an rc error code in case !CONFIG_STORAGE_MULTI
because its discarded here:

#else /* ndef CONFIG_STORAGE_MULTI */

+ storage_thread_init();

   return 0;
Closed by  speachy
2020-08-24 18:38
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Fixed in c7cbd494eb


Indeed but what is the consequence?

pretty sure storage_read_sectors would catch it eventually

fip commented on 2019-02-08 21:09

in normal operation, maybe not so much..but I ran into it when debugging ATA errors with
a harddisk replacement…so in such case the resulting misleading error codes are quite a pain!!


Available keyboard shortcuts


Task Details

Task Editing