Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#13154 : rc error code discarded in storage_init

Rockbox

Tasklist

FS#13154 - rc error code discarded in storage_init

Attached to Project: Rockbox
Opened by federico pelupessy (fip) - Sunday, 01 April 2018, 19:34 GMT
Task Type Bugs
Category Battery/Charging
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Medium
Priority Normal
Reported Version Release 3.14
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I think commit 1654efc31339972d0e6bd41a499fcffc0a45822e introduces the following error:
storage_init in firmware/storage.c does not return an rc error code in case !CONFIG_STORAGE_MULTI
because its discarded here:

#else /* ndef CONFIG_STORAGE_MULTI */
+ STORAGE_FUNCTION(init)();
+#endif /* CONFIG_STORAGE_MULTI */

+ storage_thread_init();
return 0;

This task depends upon

Comment by Willliam W (Bilgus) - Monday, 10 December 2018, 16:15 GMT
https://github.com/Rockbox/rockbox/blob/master/firmware/storage.c#L332

Indeed but what is the consequence?

pretty sure storage_read_sectors would catch it eventually
Comment by federico pelupessy (fip) - Friday, 08 February 2019, 21:09 GMT
in normal operation, maybe not so much..but I ran into it when debugging ATA errors with
a harddisk replacement...so in such case the resulting misleading error codes are quite a pain!!

Loading...