- Status Unconfirmed
- Percent Complete
- Task Type Bugs
- Category Battery/Charging
- Assigned To No-one
- Operating System All players
- Severity Medium
- Priority Very Low
- Reported Version Release 3.14
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#13154 - rc error code discarded in storage_init
I think commit 1654efc31339972d0e6bd41a499fcffc0a45822e introduces the following error:
storage_init in firmware/storage.c does not return an rc error code in case !CONFIG_STORAGE_MULTI
because its discarded here:
#else /* ndef CONFIG_STORAGE_MULTI */
+ STORAGE_FUNCTION(init)();
+#endif /* CONFIG_STORAGE_MULTI */
+ storage_thread_init();
return 0;
https://github.com/Rockbox/rockbox/blob/master/firmware/storage.c#L332
Indeed but what is the consequence?
pretty sure storage_read_sectors would catch it eventually
in normal operation, maybe not so much..but I ran into it when debugging ATA errors with
a harddisk replacement…so in such case the resulting misleading error codes are quite a pain!!