Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 FS#13197 : 'playlist buffer full' but playlist size is smaller than 'max playlist size'

Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Playlists
  • Assigned To
    Bilgus
  • Operating System Sansa Clip Zip
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.15
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by koniu - 2020-05-18
Last edited by Bilgus - 2020-05-20

FS#13197 - 'playlist buffer full' but playlist size is smaller than 'max playlist size'

With playback active, opening a large playlist from “Playlist Catalogue” results in ‘playlist buffer full’ message and truncated playlist length. It works fine with playback stopped or by opening the playlist through the file browser.

Player is Sansa Clip Zip with 256GB SD

Playlist has ~21k entries.

‘Max playlist size’ set to 30k.

Playlist gets truncated at 16384.

IRC log: https://www.rockbox.org/irc/log-20200518#15:00

Closed by  Bilgus
2020-05-20 16:41
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

G#2376

Admin
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

Notes:
limiting occurs here:
https://github.com/Rockbox/rockbox/blob/master/apps/playlist_viewer.c#L363

Max files in playlist enforced here:
https://github.com/Rockbox/rockbox/blob/master/apps/playlist.c#L2896

Admin

If tracks were already playing (dynamic playlist or otherwise)
The original code only gave half the plugin buffer to a playlist loaded from file

On some targets half the plugin buffer is not enough to load all entries…

Now we attempt to get as many entries possible while at least leaving a small buffer (MAX_PATH) for the name buffer

I've already done quite a bit of testing on my clipzip with no ill effect but more testing is warranted

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing