Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Low
  • Reported Version Release 3.15
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Bilgus - 2020-09-05
Last edited by speachy - 2021-05-12

FS#13238 - Haas surround + timestretch causes crash

Steps to reproduce

@Boot time stretch = false
Haas surround = disabled

Play Song

enable timestretch
enable Haas Surround

Tracked crash down to here:
https://github.com/Rockbox/rockbox/blob/master/lib/rbcodec/dsp/surround.c#L81

static void dsp_surround_flush(void)
{

  memset(core_get_data(handle), 0, SURROUND_BUFSIZE);

}

removing the memset stops the crash at the expense of dirty data blasting in your ears

testing the handle doesn’t help the handle is valid as far as buflib is concerned

Closed by  speachy
2021-05-12 21:32
Reason for closing:  Fixed
Additional comments about closing:  

Pretty sure I fixed this in 49a2953ade02c351498b5af382a97624ad82779a

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing