Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System xDuoo X3ii
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by iMpig - 2020-09-22
Last edited by Solomon Peachy - 2020-10-06

FS#13241 - xDuoo X3ii - Power button ignores locked state

When the player is locked user expects all (but the unlock) keypresses to be ignored and to be able unlock the player by repeating the lock procedure without the fear to shut it down accidentally.

xDuoo X3ii has two problems here:

1) Short press of the power button acts as the STOP command even hen locked. This can easily happen in a pocket.

2) To unlock the player user has to press and hold the power button (as expected). However holding the same button just slightly longer the player shuts down immediately after unlocking whitout the user being able to react.

Suggested behavior of the power button when locked:
* Ignore short presses.
* Longer press should unlock (already so).
* Don’t allow power off (extra long press) when locked. User has to first unlock the player.

Suggested behavior of the power button when unlocked:
* Short press means STOP (already so).
* Longer press means LOCK (already so).
* Extra long press means SHUT DOWN (already so, but it would benefit from a slightly increased press time OR an additional “Do you wish to shut down?” prompt)

Thank you for your time!

Tested on the daily build 1f9e16e.

Closed by  Solomon Peachy
2020-10-06 10:56
Reason for closing:  Fixed
Willliam W commented on 2020-09-25 13:49

This is a hosted device and looking at the button_read command it looks to be set up properly

it is quite possible the underlying device is doing this (power off)

iMpig commented on 2020-10-05 17:24

May be so. I hope it's solvable.

All I can add is that the "host/original firmware" does not act this way, it understands that the "unlock" needs to be different than just a short press of the power button.

It's also interesting that the option "fist button press enables backlight only" is also ignored in this case while it works for other buttons correctly.

 
Ori Avtalion commented on 2020-10-05 20:50

For the power button, the similarity "Longer press" and "Extra long press" is confusing. As I reported in  FS#13245 , You have to go through a lock/unlock cycle when you want to shut down the device.

Admin
Solomon Peachy commented on 2020-10-05 22:23

the way "soft lock" was implemented on the x3ii (and x20) is.. IMO, quite braindead. I'm going to rip it out completely, as it clearly doesn't work properly, in favor of the approach used on the AGPTek Rocker.

It's going to require reshuffling the keymaps around a little though.

Admin
Solomon Peachy commented on 2020-10-05 22:59

This should be resolved in commit 914114fd2. It'll probably be about 30 minutes before the build finishes.

iMpig commented on 2020-10-06 07:11

I've tested the new build for a few minutes -
Thank you, this is now implemented much nicer!

User can still power down from locked locked state with just one really long button press (I would prefer if powering down would just be available from unlocked state), but this is now much better and probably good enough for 99% of situations.

Thank you!

iMpig commented on 2020-10-06 10:10

Small nitpick, may be a separate / theme problem:

The messages "buttons locked" and "buttons unlocked" remain (partially) visible under the album artwork after un/locking.
Albums without artwork don't have the problem.
Tested on "cabbiev2" theme.

Admin
Solomon Peachy commented on 2020-10-06 10:55

yeah, that's a separate display refresh issue (that is not target-depedent)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing