Rockbox

Tasklist

FS#1326 - status bar disappears during recording

Attached to Project: Rockbox
Opened by Anonymous Submitter - Wednesday, 07 May 2003, 14:15 GMT
Last edited by Daniel Stenberg (bagder) - Friday, 05 December 2003, 09:22 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

It reappears briefly every minute when time is updated.
When leaving the recording screen, it returns as
normal.

john.donahue@excite.com
JBR FM ver1.30j
Rockbox ver CVS-030507
ROM: 1.23
Mask: 0x0304
USB: pos
ATA: 0x200
PR: pos
Freq: 11.0592MHz
This task depends upon

Closed by  Daniel Stenberg (bagder)
Friday, 05 December 2003, 09:22 GMT
Reason for closing:  Fixed
Comment by Vincent Kujala (vkujala) - Monday, 12 May 2003, 23:17 GMT

I can confirm that this also occurs on my JBR FM 20 with
daily builds archos20030430.ajz thru archos20030512.ajz
and perhaps as early as archos20030422.ajz (don't have em),
but does not occur with archos20030421.ajz and earlier.

[Hardware info]
ROM: 1.23
Mask: 0x0304
USB: positive
ATA: 0x200
PR: positive
Freq: 11.0592MHz

[Internal]
JBR-FM v2.1 (firmware 1.30i)
Micronas MAS 3587F B2 (2333 57 LKX)
Archos DCMP3J HD6437034R14X
SST MPF 39VF020 90-4C-WH
INsystem ISD300A1
MT 0044 4LC1M16E5-6Z (2Mbyte memory)
Hitachi DK23DA-20F
Comment by Anonymous Submitter - Friday, 16 May 2003, 12:38 GMT

The Digest for Apr23/03 mentions a change log for status
bar updating. Maybe that fix caused the problem. The dates
on the problem builds seem to coincide.
john.donahue@excite.com
Comment by Vincent Kujala (vkujala) - Friday, 23 May 2003, 02:21 GMT

I managed to resolve this one by setting status_draw(true) in
recorder.c CVS-030521 around line 430 as per this patch:

@@ -430,7 +487,7 @@
global_settings.rec_quality);
lcd_puts(0, 6, buf);

- status_draw(false);
+ status_draw(true); /* i like to see the
status */

lcd_update();
}
Comment by Vincent Kujala (vkujala) - Saturday, 24 May 2003, 17:41 GMT

Ok, here's a clean patch for cvs-030521 (previously posted
patch was mangled with other patches sorry):
http://www.geog.ubc.ca/~kujala/cvs_20030521_bug_733896.diff
Official rockbox developers, feel free to upload this patch.
-vincent.
Comment by Anonymous Submitter - Sunday, 25 May 2003, 01:16 GMT

Is status_draw(false) causing it to disappear or is it just
saying 'dont bother rewriting an unchanged status'?

Is the cause instead line ~235 in status.c:
lcd_clearrect(0,0,LCD_WIDTH,8);
which is being executed even though status is unchanged?

JohnD
Comment by Björn Stenberg (zagor) - Monday, 26 May 2003, 09:27 GMT

Fixed. Your patch was correct vkujala.

JohnD: The status bar area is only cleared when
force_redraw (or a few other conditions) are true.

Loading...