Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Very Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by Aidan MacDonald - 2021-03-22
Last edited by Solomon Peachy - 2021-03-28

FS#13278 - Spurious error message after playing a song for the first time

After installing Rockbox for the first time and selecting a song, it will display “Error accessing playlist control file” and then proceed to play the song. There’s no actual ill effect to the message, and it goes away after the first time, but it is a minor annoyance.

The problem appears to have been introduced by 46085c897854 in the function playlist_modified():

bool playlist_modified(const struct playlist_info* playlist)
{
    if (!playlist)
    {
        playlist = &current_playlist;
        if (!playlist->control_created && playlist_resume() == -1)
            return false;
    }

    ...
}

The call to playlist_resume() will fail if the playlist control doesn’t exist or can’t be loaded correctly, and display a splash screen. In this case playlist_modified() will return false.

One easy fix is adding a ‘quiet mode’ parameter to playlist_resume() to avoid showing splash messages. I could submit a patch to do this, but the deeper problem is that playlist_resume() assumes the caller somehow knows there is actually something to resume. It might be worth fixing that instead of “just get rid of the annoying message”.

For example “Resume playback” on the root menu avoids spurious messages by checking global_status.resume_index != -1.

Closed by  Solomon Peachy
2021-03-28 00:25
Reason for closing:  Fixed

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing