Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Utils
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Rbutil git
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by aakcaagac - 2021-12-28
Last edited by bluebrother - 2021-12-28

FS#13333 - Rbutil Qt can not be build anymore!

Hello,

as the summary mentions, I can not build rbutilqt from git anymore.

I know the code is going through some sort of refactoring now and that it has been put into the utils folder and so on. But the reason for this bug is this commit:

https://git.rockbox.org/cgit/rockbox.git/commit/?id=eb8dc75d3808c93068df232ddb3afda704cc36bb

This doesn’t work!

Let me explain.

I’ve been compiling RockBox ocassionally every 2-3 weeks to get an update for my player and build it over night with an automated script.

The script grabs a current master snapshot from:

https://git.rockbox.org/cgit/rockbox.git/snapshot/${RB_ROOT}.tar.bz2

Where ${RB_ROOT} points to RB_ROOT=”rockbox-master”

So what it does is - it grabs the latest tarball that your git system generates without using git from your git system by using wget.

The contents doesn’t contain all necessary git metadata (which I left out on purpose).

Over the past couple of years this worked flawlessly. Grab, Compile, Install, Grab, Compile, Install and so on.

Now the commit above changed all this by using the git tools (which I have installed as well) to extract the git HASH informations from git to construct a gitversion.h file (by doing a bunch of #defines). Unfortunately git is not able to extract these informations if rockbox was downloaded through a snapshot as shown above by me.

Right now I added a section in my automated bash script to generate a dummy gitversion.h file by generating a random hash number and a date (to satisfy what the real commit intends to do) but this is clearly not a goot way.

Just wanted to let you know that there are people outside who wget the latest snapshots rather than using git. These people need to be able to build rbutilqt as well.

Cheers and happy NY.

Closed by  bluebrother
2021-12-28 09:44
Reason for closing:  Works For Me
Additional comments about closing:  

qmake was not intended to be kept, and thus broke along the way. It will be removed soon. As you already figured, use cmake instead. For cmake this works just as expected for me.

Oh nearly forgot!

As of now NO gitversion.h is created if I continue building rbutilqt as I did before!

qmake-qt5
make

So basicly the fallthrough by setting N/A and M never creates a gitversion.h

Dumped qmake-qt5 in favor to cmake. Closing.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing