FS#13354 : WPS wrong formatting logic for strings with combination of left center and right aligning

Status Closed
Percent Complete
100%
Task Type Bugs
Category User Interface
Assigned To No-one
Operating System Sansa Clip Zip
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by bahus - 2022-06-12
Last edited by speachy - 2022-10-31

FS#13354 - WPS wrong formatting logic for strings with combination of left center and right aligning

Time Elapsed/Remaining is incorrectly displayed for long files (audiobooks):
1) Missing seconds part of remaining time and wrong centering:
Instead of “48:36 2/14 12:07:15” it shows “48:36 2/14 12:07” See attached MissingSecondsRemainingWrongCentering.bmp
2) Centered text is duplicated
See attached DuplicatedAndWrongRemaining.bmp
It should looks something like “11:38:29 2/14 1:12:10”

Seems text is properly displayed only when left and right part (Elapsed and Remaining time) need the same amount of space. So basically if both elapsed and remaining time can be expressed as h:mm:ss - everything is OK. See attached Ok.bmp. But if elapsed mm:ss and remaining h:mm:ss or vice versa - formatting is wrong.

I’m using a slightly modified standard Cabbie2 WPS (attached) and use the following format string for Time Elapsed/Remaining: %al%pc%ac%pp/%pe%ar%pr

https://www.rockbox.org/tracker/task/12980 might be related

MissingSecondsRemainingWrongC... (18.1 KiB)

DuplicatedAndWrongRemaining.b... (18.1 KiB)

cabbiev2.wps (1.5 KiB)

OK.bmp (18.1 KiB)

Closed by speachy
2022-10-31 07:12
Reason for closing: Fixed

Comments (4)
Related Tasks (0/0)

bahus commented on 2022-06-14 15:50

Formatting looks OK in 3.13 and broken in 3.14

bahus commented on 2022-06-14 16:32

So it seems the culprit in some of the following commits
https://github.com/Rockbox/rockbox/commits/v3.14/apps/gui/skin_engine

First page covers most of 3.14 commits

bahus commented on 2022-10-27 16:23

Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

I found the problematic commit: https://github.com/Rockbox/rockbox/commit/532b8141ab24f386e35f389277b4f3bc67211ed5

Reverting it solves both my and https://www.rockbox.org/tracker/task/12980 issues.

bahus commented on 2022-10-31 06:30

Fixed by https://github.com/Rockbox/rockbox/commit/202eb8c06a0b2454b9b2ab0314fc43620f011e16

	Tasks related to this task (0)

Loading...

Keyboard shortcuts

Available keyboard shortcuts

Alt + ⇧ Shift + l Login Dialog / Logout
Alt + ⇧ Shift + a Add new task
Alt + ⇧ Shift + m My searches
Alt + ⇧ Shift + t focus taskid search

Tasklist

o open selected task
j move cursor down
k move cursor up

Task Details

n Next task
p Previous task
Alt + ⇧ Shift + e ↵ Enter Edit this task
Alt + ⇧ Shift + w watch task
Alt + ⇧ Shift + y Close Task

Task Editing

Alt + ⇧ Shift + s save task