Rockbox

  • Status New
  • Percent Complete
    0%
  • Task Type Bugs
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Medium
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dconrad - 2022-12-10
Last edited by dconrad - 2022-12-11

FS#13382 - Cannot add "Haas Surround" to quickscreen

I know for sure this one’s a regression. I spoke way too soon! This appears to have been a preexisting bug uncovered for some reason by an unrelated patch.

I can no longer add “Haas Surround” to the quickscreen. Just now, I did get it to work, but then I tried it again and it crashed again, so I will try to make the reproduction procedure as foolproof as possible. It seems to depend on whether audio is playing when the setting is added?

Tested on version 7a00ad72. Bisecting to follow.

There’s two parts to this: I can add it and it shows up on the quickscreen, but if I try to change it I get a TLB refill crash. Alternatively, if I add it and shut down the player, the setting is no longer there when I boot it up again.

To reproduce:

  1. Start with no QS Bottom setting.
  2. Have Haas Surround set to Off
  3. Have music playing
  4. Go to the WPS
  5. Open Context menu, go into Sound Settings, add Haas Surround –> Haas Surround as QS Bottom
  6. Back out of context menu with back button
  7. Open QS, attempt to change Haas Surround setting
  8. TLB Refill crash

The setting being saved is similar:

  1. Start with no QS Bottom setting.
  2. Have Haas Surround set to Off
  3. Have music playing in the WPS
  4. Open Context menu, go into Sound Settings, add Haas Surround –> Haas Surround as QS Bottom
  5. Back out of context menu with back button
  6. Turn off player
  7. Turn off player, start playback, open QS. Setting isn’t there.

Still occurs in f3b522 (bugfix: for Eros Q / Surfans F20, when the scroll wheel is moved,… 2022-12-07)
Still occurs in 88ecaf (bookmark.c remove static bookmark buffer, 2022-11-25)
Still occurs in 0b7a38 (open_plugins add name when plugin can't open & check LANG_LAST_INDEX_IN_ARRAY, 2022-11-17)
Not present in 744ea2f (x1000: Allow SPL and bootloader to pass arguments to next stage, 2022-10-28)
Not present in 30ec10c790 (splash.c Fix yellow const char, 2022-11-12)
Not present in cca954e4 ( FS#13363 : Update Serbian Translation (Anonymous 'bugmenot' user), 2022-11-15)
Not present in dfa1539 (Bug Fix test_viewports.c call scroll_stop before changing viewports, 2022-11-16)
Occurs in 2f278af760 (codecs: alac: Improve resume accuracy and clean up rounding errors, 2022-11-16)
Occurs in ea61347 (codecs: aac: Prefer to resume by time instead of offset, 2022-11-16)

Occurs in 5fdd491 (playlist: reduce memory usage for loading playlists, 2022-11-16)
Verified does not occur in dfa1539b (Bug Fix test_viewports.c call scroll_stop before changing viewports, 2022-11-16)

I'm not sure how 5fdd491 could have caused this though. Currently doing a full "make zip" extraction of dfa1539b and 5fdd491 to verify that that's the culprit.

Yeah, after double checking it really does seem to be the culprit. … Why though I have no idea??

Admin

If the player crashes before a reboot it won't be there after so add it the restart

oddly If I get it added to the QS then try it after boot it locks up my ClipZip
but so far if I go to the Haas Surround setting first and change it and set it back to OFF then go back to the WPS and toggle with the QS after that it works

Admin
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

can you try this patch and see if the problem persists?
https://gerrit.rockbox.org/r/c/rockbox/+/4905

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing