Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category
  • Assigned To
    bagder
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by vkujala - 2003-05-23
Last edited by bagder - 2003-12-05

FS#1384 - settings.c config_block bug?

I suspect I ran across a bug in CVS-030521 settings.c

- if (config_block[0×29] != 0xae) { /* bug? */
+ if (config_block[0xae] != 0xff) {

The Later looks more in line with surrounding statements.
Bug consequence? fade_on_stop and caption_backlight
might occasionally be set incorrectly.

http://www.geog.ubc.ca/~kujala

   cvs_20030521_bug_742131.diff (0.5 KiB)
Closed by  bagder
2003-12-05 09:31
Reason for closing:  Fixed
vkujala commented on 2003-05-24 17:46

Here’s a proper patch.

Project Manager
bagder commented on 2003-05-27 13:11

Great catch!

I’ve applied your fix and commited it now.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing