FS#1384 - settings.c config_block bug?

Attached to Project: Rockbox
Opened by Vincent Kujala (vkujala) - Friday, 23 May 2003, 02:58 GMT
Last edited by Daniel Stenberg (bagder) - Friday, 05 December 2003, 09:31 GMT
Task Type Bugs
Status Closed
Assigned To Daniel Stenberg (bagder)
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I suspect I ran across a bug in CVS-030521 settings.c

- if (config_block[0x29] != 0xae) { /* bug? */
+ if (config_block[0xae] != 0xff) {

The Later looks more in line with surrounding statements.
Bug consequence? fade_on_stop and caption_backlight
might occasionally be set incorrectly.
This task depends upon

Closed by  Daniel Stenberg (bagder)
Friday, 05 December 2003, 09:31 GMT
Reason for closing:  Fixed
Comment by Vincent Kujala (vkujala) - Saturday, 24 May 2003, 17:46 GMT

Here's a proper patch.
Comment by Daniel Stenberg (bagder) - Tuesday, 27 May 2003, 13:11 GMT

Great catch!

I've applied your fix and commited it now.