Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jzoss - 2003-06-06
Last edited by bagder - 2003-12-05

FS#1422 - id3.c : parsenum() too specific

In new generic id3.c code, parsenum is too specific:

static int parsenum( struct mp3entry* entry, char* tag,
int bufferpos )
{

  entry->tracknum = atoi( tag );
  return bufferpos;

}

But gets called for BOTH year and tracknum tags. So
entry→year never gets set for id3v2 tags, and entry-
>tracknum will be set to year value if TYER occurs after
TRCK. String fields (yearstring, trackstring) are correct,
but associated numeric fields are wrong

Easiest fix is probably to use separate functions for
parseyear and parsetracknum.

Closed by  bagder
2003-12-05 09:31
Reason for closing:  Fixed
Project Manager

committed fix to CVS now. Thanks for reporting!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing