• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by billnapier - 2003-06-25
Last edited by zagor - 2003-07-04

FS#1473 - Another Fix for incorrect genre default value

Fix for incorrect genre default value
Currently, the dfault value for the genre value is 00.
This is a valid ID3 value (blues?). This patch sets
the value to 0xff.

This is basically the same fix as Patch #753429, but this
one includes some code cleanup as well. If fixes Bug
#649549. The code cleanup is that the entry structure
is now consistantly initialized. The v1 parsing code
didn’t init it at all, and the v2 code inited it twice. It is
now only done once, and for both v1 and v2 tags.

Closed by  zagor
2003-07-04 08:24
Reason for closing:  
Project Manager

Why do you set the entry→filesize to 4096 instead of
calling filesize()?

Mistake. That was some leftover debug code that shouldn’t
have been in there. Updated patch attached.


Available keyboard shortcuts


Task Details

Task Editing