FS#1473 - Another Fix for incorrect genre default value

Attached to Project: Rockbox
Opened by Bill Napier (billnapier) - Wednesday, 25 June 2003, 22:47 GMT
Last edited by Björn Stenberg (zagor) - Friday, 04 July 2003, 08:24 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Fix for incorrect genre default value
Currently, the dfault value for the genre value is 00.
This is a valid ID3 value (blues?). This patch sets
the value to 0xff.

This is basically the same fix as Patch #753429, but this
one includes some code cleanup as well. If fixes Bug
#649549. The code cleanup is that the entry structure
is now consistantly initialized. The v1 parsing code
didn't init it at all, and the v2 code inited it twice. It is
now only done once, and for both v1 and v2 tags.
This task depends upon

Closed by  Björn Stenberg (zagor)
Friday, 04 July 2003, 08:24 GMT
Reason for closing:  
Comment by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 25 June 2003, 23:00 GMT

Why do you set the entry->filesize to 4096 instead of
calling filesize()?
Comment by Bill Napier (billnapier) - Thursday, 26 June 2003, 12:43 GMT

Mistake. That was some leftover debug code that shouldn't
have been in there. Updated patch attached.