Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version Unstable (example)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by gadicohen - 2003-08-06
Last edited by linusnielsen - 2005-08-08

FS#1585 - Correctly display Hebrew and Arabic text (v2)

This patch introduces a compile time option for BiDi
(bidirectional) support to correctly display Hebrew and
Arabic text on your rockbox. The support is implemented
on an ‘OS’ level meaning it will affect all display
functions including directory listing, the WPS and text
file viewer.

It is assumed that you using either the ISO8859-8
(Hebrew) or ISO8859-6 (Arabic) standards to encode your
filenames on these respective filesystems. The routine
mimics the behaviour you would expect from localized
versions of the MS-Windows operating system.

Closed by  linusnielsen
2005-08-08 19:24
Reason for closing:  Accepted
Additional comments about closing:  

Logged In: YES
user_id=259137

Thanks for you patience!

Anonymous Submitter commented on 2003-08-16 23:01

ok it works for both hebrew and arabic.
but the problem by arabic is taht all the letters are display
separately ??

do you now* want * plan to integrate some code to make
the letter junction

thanks

no, there is no real plan to do this; perhaps that makes the
title a bit misleading. i can definitely look into it, but won’t
have my own PC for atleast another month. but this would
result in a BIG change to the way text is rendered, and is
almost definately a bit beyond my ability / my knowledge of
rockbox code.

Anonymous Submitter commented on 2004-04-21 00:30

i don’t know how to use this files please help me??

you need to patch this against the source and recompile it
yourself (I believe this is explained in the documentation
section of the website), atleast until such a time as the
patch is included in the regular source (not very likely – its been 8 months since the original submission).

to make things a bit easier I updated the patch against the
daily build from today (20040421) and made a few changes to
make it potentially more suited to include in the main
distribution. BiDi support is no longer a compile time
option but a runtime configuration option which is saved to
the default config. To enable, change BiDi Support to “yes” in General Settings → System.

You also need a suitable Hebrew font – the ones on the
website don’t use the correct encoding, see my post at
http://rockbox.haxx.se/mail/archive/rockbox-archive-2003-08/0070.shtml

Anonymous Submitter commented on 2004-04-21 14:44

thanks for the explainations but i just don’t understand how
to fix the hebrew problem
i don’t understand how to work with the patch file, bdf and diff
if any one could help me in any way read in hebrew the song
titles i’ll be very thankfull

Anonymous Submitter commented on 2004-04-21 16:29

e-mail me (dragon AT wastelands DOT net) with your model
type (i.e. fm recorder) and i’ll e-mail you back a new
firmware file, and the compiled font file (which you can put
in .archos/fonts and “play” it once to make it the default
font).

Anonymous Submitter commented on 2004-05-18 15:26

is it good for the jukebox studio???

as far as i know it will work on everything except a player.
if you can load fonts, you should be able to use this patch.

ok i fixed the patch against today’s release. due to some
changes in the rockbox source there’s now a compile time
warning which although its not ideal you can ignore :> i
also included main.inc which seemed to be missing… weird… if u get an error about this file its probably not
important.

i also added the compiled font in the new format you need
for the newer releases. your settings will be lost when u
upgrade, so just change to the new font again, and enable
bidi in general settings → display → lcd settings → BiDi
Hebrew/Arabic.

good luck :)

ergh this is getting quite long now :( if you want a
rockbox.zip like you’d get off the rockbox site (i.e. you
can’t or don’t want to compile rockbox with the hebrew patch
yourself) – there’s one against today’s daily build here
(20040925): http://dragon.wastelands.net/rockbox.zip

it’s on my home PC so don’t expect too much. use this just
like you’d use a rockbox.zip from the main site, it includes
all the usual stuff, just unzip it your jukebox’s main
directory. i take no responsibility for this, use it at
your own risk, but it works fine for me :)

d’oh. 3 comments in one day. i’m just curious… how many
arabic users are there? would you be interested in shaping
support? i might have worked out a way to do it… but i
need from u a screenshot of how your filenames should look
and a zip file with those filenames inside in either
ISO8859-6 or UTF-8 encoding (or preferably both). If you
want this support and/or can email me this stuff, my email
is below. You can maybe even send me some nice arabic pop :)

I have been working, downloading and messing around, the
last 6 hours in cgywin and other tools just for this patch. No
wonders (it’s old) that It doesn’t compiles smoothly. I will be
very happy if someone would fix the few small errors that are
made by the patch… as 6 hours are not enough time to learn
c++.

if it really works like it should, (that is for archos), I assume
this patch should enter the final builds, shouldn’t it? why was
this left out on the archos? (wasn’t it?)

Project Manager

Thanks for you patience!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing