Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Settings
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by cent20 - 2003-08-25
Last edited by diddystar5 - 2003-09-28

FS#1656 - Enhanced menus + MDB patch (for recorder)

Used my widgets there…

Closed by  midkay
2007-02-19 05:03
Reason for closing:  Out of Date
Additional comments about closing:  

With all the recent menu changes, new targets, etc. this can be considered out of date/unusable. As for MDB, we\'ve had it in SVN for a couple years now.

A good looking version. Text is now right aligned when a slider
is present (no more overlap between text and sliders then …
as far as i know!)
Modified lcd-recorder.c to permit a per pixel scrolling line
positioning (fixes checkbox bug).
Added a new widget (”arrow”). Used in menus to indicate a
list of different values.

I have been playing around with your patch today and I have
a few comments.

1. Could you please remove all the whitespace changes. They
make your patch outdated quicker, and harder to read.

 P.S. Could you also fix that on the MDB patch?

2. Try not to include other patches in your patch. I noticed
you included the accurate vbr ff-rew and more directory
sorting options patches.

3. Why is the fade on pause and stop renamed? is dosen’t
make any sense when it says “on Pause/Stop”

4. Your patch has some compile errors. Could you please fix
those. Also your patch dosen’t compile with the simulator.

5. Could you please post up a patch without the MDB, and
just the menu changes.

Thanks

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing