Rockbox

Tasklist

FS#1660 - A-B Repeat

Attached to Project: Rockbox
Opened by Vincent Paeder (cent20) - Wednesday, 27 August 2003, 19:24 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 06 July 2005, 21:01 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

as the title says. When in this mode, push ON to set
both positions and to unset them afterwards.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 06 July 2005, 21:01 GMT
Reason for closing:  Out of Date
Comment by Lee Pilgrim (diddystar5) - Wednesday, 27 August 2003, 21:46 GMT

Sounds like a nice feature, but dosen't this make it where you
can't go to the browser while playing?
Comment by Vincent Paeder (cent20) - Wednesday, 27 August 2003, 23:32 GMT

If you select the mode, yes, but you just have to press F2
and change back to another one. Or go to the menu if you
got a player. I considered this but i don't think it's a problem,
it wouldn't be easier to have to push some combination that
would be compatible with the player as well.
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 28 August 2003, 06:32 GMT

cent20,

Could you please try to only include the relevant changes in
the patch file? There are lots of whitespace differences,
making it hard for me to see what is changed by just
browsing the patch file.
Comment by Vincent Paeder (cent20) - Thursday, 28 August 2003, 10:12 GMT

alright. I was in trouble cos of the icons and tried a few
things so i left a lot of white spaces everywhere.
Comment by Vincent Paeder (cent20) - Thursday, 28 August 2003, 11:40 GMT

that's it!
Comment by Vincent Paeder (cent20) - Thursday, 28 August 2003, 13:43 GMT

Precision improved by adding an ab repeat thread.
Comment by Vincent Paeder (cent20) - Thursday, 28 August 2003, 18:02 GMT

Another version with code included in the mpeg thread. Has
some advantages and disadvantages. It's not that precise
anyway (could be better), and i don't think it's better than
the first precision improvement. The last step would be to
integrate the time check to the thread itself and then bypass
the event queue.
Comment by Eric Linenberg (elinenbe) - Saturday, 30 August 2003, 05:18 GMT

I have been waiting for this feature for a while. This is what
was on my Rio 300 (the first mp3 player) and I loved it!
Comment by Hardeep Sidhu (hardeeps) - Saturday, 30 August 2003, 19:41 GMT

Just in case you didn't see it, the argument passed to
mpeg_ff_rewind() was changed (actual time instead of
offset). You'll probably want to update your patch.
Comment by Vincent Paeder (cent20) - Sunday, 31 August 2003, 12:59 GMT

Some bug fixes regarding AB repeat icons here. Else :
- doesn't loop the playlist anymore, as if it was in repeat all
mode.
- patch is made for daily-20030830 so with the new
mpeg_ff_rewind function.
Comment by Vincent Paeder (cent20) - Sunday, 31 August 2003, 18:20 GMT

New addition :

If both markers are set, pushing ON for 0.5 sec shows up a
menu which allows modifying those.

Patch for daily-20030830.
Comment by Anonymous Submitter - Wednesday, 21 January 2004, 19:33 GMT

This patch appears to be broken with the more current
versions of rockbox (since mid-December through to now):

7 hunks fail to be patched...settings_menu.c, mpeg.h, and
others. Does anyone have any luck with this?
Comment by Shervin Riahi (sherv) - Wednesday, 21 January 2004, 19:37 GMT

This patch appears to be broken with the more current
versions of rockbox (since mid-December through to now):

7 hunks fail to be patched...settings_menu.c, mpeg.h, and
others. Does anyone have any luck with this?
Comment by Anonymous Submitter - Tuesday, 27 January 2004, 16:49 GMT

Yes, I have applied it recently. I will update it and upload it
ASAP.
Comment by Shervin Riahi (sherv) - Tuesday, 27 January 2004, 17:16 GMT

Great!! This patch will be an excellent addition to Rockbox,
and I really appreciate the work done on it!
Comment by Anonymous Submitter - Saturday, 08 May 2004, 06:32 GMT

No progress on this patch? :(

Loading...