Rockbox

Tasklist

FS#1687 - While recording, let Play start a new file

Attached to Project: Rockbox
Opened by Anonymous Submitter - Thursday, 11 September 2003, 00:48 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Monday, 03 November 2003, 00:18 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

On the recorder (at least in the .28 firmware) you can
press "Next" at any time to start a new recording. It picks
up from the previous one with no gap (in fact there may be
a little overlap, I haven't had time to check yet). This is
very handy for live recordings where you want to put each
song in a new file.

I haven't had a chance yet to set up a build environment
to even go so far as to compile, let alone install, this stuff.
(I only switched to RockBox yesterday). But the following
is a cut-and-paste change to recording.c which I believe will
provide this functionality. I simply included what seemed
to be the appropriate code from the OFF button into the
PLAY button. What I don't know is whether it will lose any
audio in the process. It simply says that if we are
recording, and the play button is pressed, then we stop the
existing recording and start a new one.

Questions and comments to nazgul@somewhere.com. And
yes, next time I'll create an account and do this all right.

*** recording.c.orig Wed Sep 10 20:40:55 2003
--- recording.c Wed Sep 10 20:41:41 2003
***************
*** 207,212 ****
--- 207,219 ----
update_countdown = 1; /* Update
immediately */
last_seconds = 0;
}
+ else
+ {
+ mpeg_stop();
+ mpeg_record(create_filename());
+ update_countdown = 1; /* Update
immediately */
+ last_seconds = 0;
+ }
break;

case BUTTON_UP:
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Monday, 03 November 2003, 00:18 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES
user_id=259137

Thank you for you patch. We have solved it ourselves, along
with the frame accurate split feature.
Comment by Kee Hinckley (khinckley) - Monday, 22 September 2003, 00:33 GMT

(This was my patch, but I didn't have an SF account at the
time.)

I now have an SF account, and I've built and installed this patch.
1. It does compile.
2. It does work, however there is a small gap between
recordings. Oddly the sound is lost at the end of the first
recording, so it looks as if some buffer isn't being flushed. It's
conceivable that this is a general problem, I'll take a look at it
when I have a chance.
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 03 November 2003, 00:18 GMT

Thank you for you patch. We have solved it ourselves, along
with the frame accurate split feature.

Loading...