Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#1783 : Organize rockbox/Rocks directory

Rockbox

Tasklist

FS#1783 - Organize rockbox/Rocks directory

Attached to Project: Rockbox
Opened by Henrik Backe (hbacke) - Tuesday, 04 November 2003, 18:11 GMT
Last edited by Björn Stenberg (zagor) - Monday, 19 January 2004, 15:30 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

There have been frequent requests for a better
organizations of the .rockbox/Rocks directory,so here is
a patch.

This patch should be seen as the basis for a discussion
of how it could be done rather than "the" solution
(even more so than my organize .rockbox patch).

It adds the directories Applications, Demos, Games and
Viewers to the .rockbox/rocks directory.

I've changed the rockbox browser so it can browse
directories for plugins, so the code is almost independent
from the directory structure in .rockbox/Rocks.
The only exception is the Viewers directory where
all plugins that needs to be started by playing a file,
are located.

The Viewers directory is hidden when using the plugin
browser, because starting these plugins without
input is meaningless. I have chosen to exclude the
Viewers directory in the code rather than taking the
easy way out and call it .Viewers, because I think that
the directory structure should be built already at compile
time.

I've also attached a makefile patch to show how I think
the Rocks structure should be built. My makefile patch
is only a hack with at least one major drawback (you
have to add each plugin to the makefile) the proper way
would be to have the same structure in apps/plugins
as in .rockbox/rocks


.../Henrik
This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 19 January 2004, 15:30 GMT
Reason for closing:  
Comment by Henrik Backe (hbacke) - Wednesday, 10 December 2003, 13:26 GMT

Updated to latest cvs,
Th categories are changed to apps,games, demos and viewers
Comment by Henrik Backe (hbacke) - Wednesday, 07 January 2004, 15:46 GMT

Updated to latest cvs
Comment by Henrik Backe (hbacke) - Thursday, 08 January 2004, 20:36 GMT

Changed .rockbox/rocks/viewers to .rockbox/viewers.

I've also delete the Makefile changes since the proposed
changes in the build system for .rock viewers is better way to
handle subfolders in the rocks directory.

../Henrik
Comment by Eric Linenberg (elinenbe) - Thursday, 08 January 2004, 21:15 GMT

I have set this up the way I thought was correct, but nothing
shows up in the plugins dirs. Maybe I am doing something
wrong though.
Comment by Henrik Backe (hbacke) - Thursday, 08 January 2004, 21:26 GMT

You're right, I think it might be that I have not followed
[IDC]Dragon's changes for viewing. I'm on the case.

../Henrik
Comment by Henrik Backe (hbacke) - Thursday, 08 January 2004, 21:45 GMT

Ok, now it works again.

.../Henrik
Comment by Eric Linenberg (elinenbe) - Thursday, 08 January 2004, 21:52 GMT

since you are busy updating it -- it would be nice if it was
merged with the latest CVS. It is just a little change in the
tree.c
Comment by Henrik Backe (hbacke) - Thursday, 08 January 2004, 22:08 GMT

I'ts only some whitespace stuff that causes problems for you.

"patch -l < organize_rocks_dir.diff" will apply the patch
cleanly.

.../Henrik
Comment by Henrik Backe (hbacke) - Friday, 09 January 2004, 14:24 GMT

The patch is even more simplified now.

.../Henrik
Comment by Henrik Backe (hbacke) - Monday, 19 January 2004, 15:18 GMT

This patch is discontinued.

patch http://sourceforge.net/tracker/index.php?
func=detail&atid=439120&group_id=44306&aid=879411
has larger scope, so use it instead.

.../Henrik

Loading...