FS#1821 - Recorder scrolling bug fixes

Attached to Project: Rockbox
Opened by Craig Sather (rb_dev) - Wednesday, 26 November 2003, 03:40 GMT
Last edited by Daniel Stenberg (bagder) - Tuesday, 13 January 2004, 14:59 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To Daniel Stenberg (bagder)
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


This patch fixes two bugs associated with lcd_puts and
scrolling on the recorder.

1 - Unlike the implementation in the player code, on
the recorder a call to lcd_puts does not stop the
scrolling text from a previous lcd_puts_scroll call, so
the new line gets overwritten by the old scrolling
text. More discussion and details can be found at:

2 - When the function lcd_puts_scroll_style is called
with an x offset greater than 0, the scrolling text is
placed at an offset of 2x instead of x.

This task depends upon

Closed by  Daniel Stenberg (bagder)
Tuesday, 13 January 2004, 14:59 GMT
Reason for closing:  Accepted
Comment by Daniel Stenberg (bagder) - Monday, 12 January 2004, 16:18 GMT

Is this still valid? If so, can you update it to current CVS
and only make the for() loop in lcd_puts_style if there
actually is at least one line scrolling:

if(scrolling_lines) {
[bla bla]

(I'll take a stab on your alternating WPS patch next, once
we've fixed this.)
Comment by Craig Sather (rb_dev) - Monday, 12 January 2004, 19:44 GMT

Yes this is still valid. I will add the change you suggest
and submit a patch updated to the current CVS.
Comment by Craig Sather (rb_dev) - Monday, 12 January 2004, 20:31 GMT

Patch updated.