Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category LCD
  • Assigned To
    bagder
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rb_dev - 2003-11-26
Last edited by bagder - 2004-01-13

FS#1821 - Recorder scrolling bug fixes

This patch fixes two bugs associated with lcd_puts and
scrolling on the recorder.

1 - Unlike the implementation in the player code, on
the recorder a call to lcd_puts does not stop the
scrolling text from a previous lcd_puts_scroll call, so
the new line gets overwritten by the old scrolling
text. More discussion and details can be found at:
http://rockbox.haxx.se/mail/archive/rockbox-archive-2003-11/0531.shtml

2 - When the function lcd_puts_scroll_style is called
with an x offset greater than 0, the scrolling text is
placed at an offset of 2x instead of x.

   scroll.patch (2.9 KiB)
   scroll.0112.patch (3 KiB)
Closed by  bagder
2004-01-13 14:59
Reason for closing:  Accepted
Project Manager
bagder commented on 2004-01-12 16:18

Is this still valid? If so, can you update it to current CVS and only make the for() loop in lcd_puts_style if there
actually is at least one line scrolling:

if(scrolling_lines) { 

 [bla bla]

}

(I’ll take a stab on your alternating WPS patch next, once
we’ve fixed this.)

rb_dev commented on 2004-01-12 19:44

Yes this is still valid. I will add the change you suggest
and submit a patch updated to the current CVS.

rb_dev commented on 2004-01-12 20:31

Patch updated.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing