- Status Closed
- Percent Complete
- Task Type Patches
- Category
- Assigned To No-one
- Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by langhaarrocker - 2003-12-31
Last edited by linusnielsen - 2005-04-04
Opened by langhaarrocker - 2003-12-31
Last edited by linusnielsen - 2005-04-04
FS#1899 - volume triggered recording
This closes feature request No 611717
(http://sourceforge.net/tracker/index.php?func=detail&aid=611717&group_id=44306&atid=439121)
Add a new menu item “trigger” to the recording menu. Once the trigger properties are defined you can arm the trigger by pressing play in the record screen.
There are some issues still to be fixed before this should be committed:
- When peak meter is in logarithmic mode the control of the trigger thresholds is lousy
- Configuration of the trigger can be saved in a config file, but not yet in rtc or anywhere else where the last settings are restored.
Phil
recledtrig_bar.patch
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Wow! Thats very usefull for me. My dad is always wanting me
to record some of his old tapes to cd, and getting the
correct start is hard to estimate, and saves time in mp3
driect cut. Thanks Phil!
This new patch
- fixes the lousy db control issue
- settings are stored and restored
- prerecord time control added
- in recording screen the trigger setup can be opened with f3
- dropout time limited to max 2s
- response at start duration 0s improved
- unified some code
I consider it as code-police-ready.
Phil
This patch works great here. Also, nice to see you back
Phillipp! Maybe the time has come for configurable F menus
and other keys :D
Some changes as proposed by Martin Borus
- Thresholds limits adapted, special values have names like off, or -inf.
- Trigger modes renamed
- optical feedback on trigger states
- What about prerecording == record_pause? I turned on that orphant icon.
This patch not only closes the feature request 611717 as
stated above but closes feature request 882036 too (http:
sourceforge.net/tracker/index.php?
func=detail&group_id=44306&atid=439121&aid=882036), which
is a perfect dupe. This goes very well with feature request 603469 (http:
sourceforge.net/tracker/index.php?
func=detail&group_id=44306&atid=439121&aid=603469), which
requests a silence detection.
As the new Audio_3587 plugin requires a new build I would like
to include this in the Cyborg Systems branch of Rockbox.
Are you happy that it is finished now?
BlueChip
I updated the patch to match the current cvs. Still a few quirks in it :(
Phil
fixed:
- retrigger seems to work
- led doesn’t blink in quickscreens
stupid me uploaded a broken patch file
synched with V2.3
Just because of the joy of it I uploaded a patch that
combines triggered recording with the recled patch 1055147.
It is more than a plain combination as changes in
recording.c were necessary. If someone agrees that both
(triggered recording _and_ recled) should be applied then I
recommend to use the patch file recledtrig.patch to make it
easier.
FYI: Documentation for this patch can be found on these two
sites:
http://www.rockbox.org/twiki/bin/view/Main/TriggerManual
http://www.rockbox.org/twiki/bin/view/Main/VolumeTriggeredR ecording
The new patch has a different display for the trigger states. It doesn’t use the traffic light symbol any more but something like a progress bar. It’s bigger and I had to sacrifice the display of the sample rate when recording from line in.
Maybe someone likes it.
Phil
I’m too stupid to upload a file at first try. grrr.