Rockbox

Tasklist

FS#1940 - Viewing files with plugins.

Attached to Project: Rockbox
Opened by Henrik Backe (hbacke) - Sunday, 18 January 2004, 19:54 GMT
Last edited by Björn Stenberg (zagor) - Saturday, 22 May 2004, 00:43 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Here is my attemt to implement the scheme in mail
http://rockbox.haxx.se/mail/archive/rockbox-archive-
2004-01/0386.shtml
This patch is not completete yet, it is still a proof of
concept.

I've made a few changes to this scheme.
- /.rockbox/viewers.config and /.rockbox/viewers are
read/scanned at bootup if no /.rockbox/.viewers.cache
exist. This way we always know what extensions are
supported, and we only get excessive filereads on the
first boot.
- /.rockbox/viewers.config and /.rockbox/viewers are
not read/scanned when a viewer plugin is called.
Instead there is a refresh of .viewers.cache
if a plugins is missing or have filesize zero.
- If a new viewer plugin is added .viewers.cache has to
be refreshed, since this will not be done automagically
I've added an option to
settings->system-manage settings->reset plugin list
- I've made the assumption that for example
txt-viewer.rock and viewer.rock will be in
the /.rockbox/viewers folder, and then no rocks with
an extension prefix should be displayed in the
onplay->"open with" menu.

Things left to do
- code policeing
- commenting of the code
- add splashes for some of the error conditions
- add language strings
- figure out a sane value for string_buffer in filetypes.c
It's set to 1000 bytes, but I think it can be reduced.
- One known bug, A second reset of the plugin list will
freeze the unit.

Daniel's patch mentioned in
http://rockbox.haxx.se/mail/archive/rockbox-archive-
2004-01/0461.shtml
should be applied before this patch.
This task depends upon

Closed by  Björn Stenberg (zagor)
Saturday, 22 May 2004, 00:43 GMT
Reason for closing:  Accepted
Comment by Henrik Backe (hbacke) - Monday, 19 January 2004, 14:44 GMT

The reset bug is now solved.

.../Henrik
Comment by Henrik Backe (hbacke) - Monday, 19 January 2004, 18:47 GMT

Sane values for buffers and tables,
filesize zero checked when viewers.config read,
compiles for the player.

I think the logic is there now, tome for code policeing.

.../Henrik
Comment by Henrik Backe (hbacke) - Tuesday, 20 January 2004, 16:22 GMT

code policeing, splashes, comments and language strings
done. A few bugs crushed also.

The only thing left to do, if there ar no bugs left, is to
remove DEBUGF statements from filetypes.c

.../Henrik
Comment by Henrik Backe (hbacke) - Wednesday, 21 January 2004, 11:05 GMT

Added a missing language string,
verification of viewers when reading viewers.config
removed.

.../Henrik
Comment by Henrik Backe (hbacke) - Tuesday, 27 January 2004, 10:51 GMT

Updated to latest cvs
Comment by Henrik Backe (hbacke) - Saturday, 13 March 2004, 22:17 GMT

Updated to latest cvs.

.../Henrik
Comment by Henrik Backe (hbacke) - Monday, 15 March 2004, 20:08 GMT

Updated to latest cvs.

.../Henrik
Comment by Henrik Backe (hbacke) - Tuesday, 16 March 2004, 21:14 GMT

Updated to latestcvs.

.../Henrik
Comment by Henrik Backe (hbacke) - Wednesday, 17 March 2004, 20:25 GMT

Updated to daily cvs

.../Henrik
Comment by Henrik Backe (hbacke) - Friday, 21 May 2004, 18:31 GMT

Updated to latest cvs.


.../Henrik

Loading...