- Status Closed
- Percent Complete
- Task Type Patches
- Category
- Assigned To No-one
- Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#1940 - Viewing files with plugins.
Here is my attemt to implement the scheme in mail
http://rockbox.haxx.se/mail/archive/rockbox-archive-
2004-01/0386.shtml
This patch is not completete yet, it is still a proof of
concept.
I’ve made a few changes to this scheme.
- /.rockbox/viewers.config and /.rockbox/viewers are
read/scanned at bootup if no /.rockbox/.viewers.cache
exist. This way we always know what extensions are
supported, and we only get excessive filereads on the
first boot.
- /.rockbox/viewers.config and /.rockbox/viewers are
not read/scanned when a viewer plugin is called.
Instead there is a refresh of .viewers.cache
if a plugins is missing or have filesize zero.
- If a new viewer plugin is added .viewers.cache has to
be refreshed, since this will not be done automagically
I’ve added an option to
settings->system-manage settings->reset plugin list
- I’ve made the assumption that for example
txt-viewer.rock and viewer.rock will be in
the /.rockbox/viewers folder, and then no rocks with
an extension prefix should be displayed in the
onplay→“open with” menu.
Things left to do
- code policeing
- commenting of the code
- add splashes for some of the error conditions
- add language strings
- figure out a sane value for string_buffer in filetypes.c
It's set to 1000 bytes, but I think it can be reduced.
- One known bug, A second reset of the plugin list will
freeze the unit.
Daniel’s patch mentioned in
http://rockbox.haxx.se/mail/archive/rockbox-archive-
2004-01/0461.shtml
should be applied before this patch.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
The reset bug is now solved.
…/Henrik
Sane values for buffers and tables,
filesize zero checked when viewers.config read,
compiles for the player.
I think the logic is there now, tome for code policeing.
…/Henrik
code policeing, splashes, comments and language strings
done. A few bugs crushed also.
The only thing left to do, if there ar no bugs left, is to
remove DEBUGF statements from filetypes.c
…/Henrik
Added a missing language string,
verification of viewers when reading viewers.config
removed.
…/Henrik
Updated to latest cvs
Updated to latest cvs.
…/Henrik
Updated to latest cvs.
…/Henrik
Updated to latestcvs.
…/Henrik
Updated to daily cvs
…/Henrik
Updated to latest cvs.
…/Henrik