Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by hbacke - 2004-01-29
Last edited by hbacke - 2005-09-23

FS#1972 - Choose behaviour of play button

Adds optional behaviour of the play button

Instead of the usual start of playlists, play
can be set to insert, insert next, or insert last.
The ordinary play is of course the default.

The new option can be founde under general settings→ playback.

This patch adresses feature requests 879433, 998157,
688344 at least partially.

…/Henrik

Closed by  zagor
2006-03-20 09:23
Reason for closing:  Out of Date
Additional comments about closing:  

Part Mode, which is nearly the same thing, is now in CVS.

Project Manager
zagor commented on 2004-01-30 10:07

This sounds a bit like what I’ve been meaning to do: Party
mode. When in party mode, no button interrupts the music. I.
e. PLAY in browser does insert next/last and STOP/NEXT in
WPS does nothing.

Are you interested in going down this road?

Sure, but why disable stop/next in wps.

I’ve added the insert next/last ability to play in this patch.
When play is set to insert next/last it won’t start the wps
it will stay the tree browser. Also inserting a track wont
interupt the music so I really don’t see the need to disable
stop/next in the wps.

I did this patch to easily build playlist, just set the play
button to insert last and start pressing play on tracks
that you fancy and save the playlist when you are done.

If you really need to be able to disable stop/next in wps
that should be a separate option , and sure I’ll do
it if you want it.

…/Henrik

Project Manager
zagor commented on 2004-01-30 11:33

My thinking with the “party mode” is that it should be able
to leave the box playing during a party, and people will
never accidentally interrupt the music.

I guess we could go all the way and make a bitmap for which
keys/functions to lock. You may even want to lock volume
adjustment too.

I see, but I think disabling the “sound” keys in wps is going to
far, since almost all of them are available from the main menu.

I believe three levels of key disabling should be enough
- None
- Navigation keys (next,prev and stop)
- Navigation keys + volume keys.

Another question, should this setting be set thru the main
menu and/or the onplay menu.

…/Henrik

First buggfix :-(, as usually in the cfg load/save code.

…/Henrik

Updated to latest cvs.

…/Henrik

Updated to daily cvs

…/Henrik

Anonymous Submitter commented on 2004-04-13 12:46

in apps/settings.c:809

config_block[0xf5]
should be
config_block[0xf6]

I presume… /JG

Right, talkbox has taken the f5 byte, I’ve changed it to
f6.

…/Henrik

Anonymous Submitter commented on 2004-04-20 14:15

Why need optional abilities of play button this is stupid!
Play should play only

As an irc-log reader I noticed that my patch was mentioned,
so here is an update.

Project Manager
zagor commented on 2005-09-22 21:57

Hehe, well spotted. However I think your patch is a bit overly advanced, at
least for what I want to do.

I want a simple “party mode” which you turn on and off in the playback menu.
This mode disables the stop, next and prev buttons in the wps and changes
some buttons in the browser so it never interrupts the currently playing music
and queues instead of starts new tracks.
I believe such a simplistic solution would solve 95% of the use cases and is
a lot easier to understand and use than your more complete solution.

I’ll tinker a bit with “my way” and see how it ends up.

It wasn’t my idea with all the different queue/mode,
personally I prefer
it your way minus the key locking, but there was a lot of
noice on the mailinglist that wanted the complete option
list so I added it.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing