FS#1972 - Choose behaviour of play button

Attached to Project: Rockbox
Opened by Henrik Backe (hbacke) - Thursday, 29 January 2004, 16:23 GMT
Last edited by Henrik Backe (hbacke) - Friday, 23 September 2005, 20:06 GMT
Task Type Patches
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Adds optional behaviour of the play button

Instead of the usual start of playlists, play
can be set to insert, insert next, or insert last.
The ordinary play is of course the default.

The new option can be founde under general settings->

This patch adresses feature requests 879433, 998157,
688344 at least partially.

This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 20 March 2006, 09:23 GMT
Reason for closing:  Out of Date
Additional comments about closing:  Part Mode, which is nearly the same thing, is now in CVS.
Comment by Björn Stenberg (zagor) - Friday, 30 January 2004, 10:07 GMT

This sounds a bit like what I've been meaning to do: Party
mode. When in party mode, no button interrupts the music. I.
e. PLAY in browser does insert next/last and STOP/NEXT in
WPS does nothing.

Are you interested in going down this road?
Comment by Henrik Backe (hbacke) - Friday, 30 January 2004, 10:28 GMT

Sure, but why disable stop/next in wps.

I've added the insert next/last ability to play in this patch.
When play is set to insert next/last it won't start the wps
it will stay the tree browser. Also inserting a track wont
interupt the music so I really don't see the need to disable
stop/next in the wps.

I did this patch to easily build playlist, just set the play
button to insert last and start pressing play on tracks
that you fancy and save the playlist when you are done.

If you really need to be able to disable stop/next in wps
that should be a separate option , and sure I'll do
it if you want it.

Comment by Björn Stenberg (zagor) - Friday, 30 January 2004, 11:33 GMT

My thinking with the "party mode" is that it should be able
to leave the box playing during a party, and people will
never accidentally interrupt the music.

I guess we could go all the way and make a bitmap for which
keys/functions to lock. You may even want to lock volume
adjustment too.
Comment by Henrik Backe (hbacke) - Friday, 30 January 2004, 11:57 GMT

I see, but I think disabling the "sound" keys in wps is going to
far, since almost all of them are available from the main menu.

I believe three levels of key disabling should be enough
- None
- Navigation keys (next,prev and stop)
- Navigation keys + volume keys.

Another question, should this setting be set thru the main
menu and/or the onplay menu.

Comment by Henrik Backe (hbacke) - Friday, 30 January 2004, 12:52 GMT

First buggfix :-(, as usually in the cfg load/save code.

Comment by Henrik Backe (hbacke) - Monday, 15 March 2004, 20:07 GMT

Updated to latest cvs.

Comment by Henrik Backe (hbacke) - Wednesday, 17 March 2004, 20:28 GMT

Updated to daily cvs


Comment by Anonymous Submitter - Tuesday, 13 April 2004, 12:46 GMT

in apps/settings.c:809

should be

I presume...
Comment by Henrik Backe (hbacke) - Tuesday, 13 April 2004, 13:24 GMT

Right, talkbox has taken the f5 byte, I've changed it to

Comment by Anonymous Submitter - Tuesday, 20 April 2004, 14:15 GMT

Why need optional abilities of play button this is stupid!
Play should play only
Comment by Henrik Backe (hbacke) - Thursday, 22 September 2005, 20:26 GMT

As an irc-log reader I noticed that my patch was mentioned,
so here is an update.
Comment by Björn Stenberg (zagor) - Thursday, 22 September 2005, 21:57 GMT

Hehe, well spotted. However I think your patch is a bit overly advanced, at
least for what I want to do.

I want a simple "party mode" which you turn on and off in the playback menu.
This mode disables the stop, next and prev buttons in the wps and changes
some buttons in the browser so it never interrupts the currently playing music
and queues instead of starts new tracks.
I believe such a simplistic solution would solve 95% of the use cases and is
a lot easier to understand and use than your more complete solution.

I'll tinker a bit with "my way" and see how it ends up.
Comment by Henrik Backe (hbacke) - Friday, 23 September 2005, 20:06 GMT

It wasn't my idea with all the different queue/mode,
personally I prefer
it your way minus the key locking, but there was a lot of
noice on the mailinglist that wanted the complete option
list so I added it.