FS#2050 - Bookmark follows repositioned MP3 file

Attached to Project: Rockbox
Opened by Steve Cundari (scundari) - Monday, 08 March 2004, 04:45 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 07 December 2004, 14:21 GMT
Task Type Patches
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


If you have a bookmark associated with a directory (rather than a playlist), the bookmark references the position of the MP3 file in that directory. If this position later changes, the bookmark becomes invalid.

For instance, if you make a bookmark on an MP3 file that is the third file in the directory, then later add a new MP3 file that is alphabetically before that file (or delete one or both of the first two files), the position of the bookmarked file will change.

Loading that bookmark would cause play to resume with the MP3 file that is in the third postion (which is no longer the same MP3 file for which you made the bookmark), resulting in confusing behavior.

This patch will cause bookmark playback to check to see if the name of the MP3 file at the index stored in the bookmark matches the name that was stored in the bookmark. If they differ, then the entire directory is searched (starting from the beginning) to find an MP3 file name that matches.

If one is found, replay resumes on that file, no matter what position it is now at in the directory.

If the file is not found (it was deleted or moved to another directory), the bookmark resume fails, and nothing is played back.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 07 December 2004, 14:21 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES

Thanks a lot Steve!
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 07 December 2004, 14:21 GMT

Thanks a lot Steve!