FS#2113 : Bookmark changes

Status Closed
Percent Complete
0%
Task Type Patches
Category
Assigned To No-one
Operating System
Severity Low
Priority Very Low
Reported Version
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by lassauge - 2004-03-31
Last edited by linusnielsen - 2004-07-14

FS#2113 - Bookmark changes

I propose several small but useful changes :

- use creat() instead of open() when creating the
files (or it won’t work on at least Cygwin)
- use ‘.bmk’ instead of ‘.bmark’ : keep the 3 letters
extension usage
- use the character 0×91 as the bookmark icon (a little
like a square root sign) for the player

The patch is based on the rockbox-daily-20040329
version.

Closed by linusnielsen
2004-07-14 12:24
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Logged In: YES
user_id=259137

Thanks Eric. This patch is now obsolete, since the open()
works in the simulator nowadays, and I just added a bookmark
icon for the player.

Comments (6)
Related Tasks (0/0)

zagor commented on 2004-03-31 11:08

Please create patches in unified diff format, using "diff -u".

Why do you want a three-letter extension? We are using
FAT32, which has no such limitations.

lassauge commented on 2004-04-01 12:44

I know that with the filesystem you can have any
extension you want, but the three-letter extension is
so common (and allready used for every rockbox file : cfg,
wps, lng ….) that I found it more "beautiful" :→ As usual, it's only a proposal ….

lassauge commented on 2004-05-27 16:14

New version of the patch:
- based on rockbox-daily-20040525
- 'diff -u' used
- stick with 'bmk' extension BUT if you don't like it
take the rest of the patch because it is usefull (creat
and icon for player) …