Rockbox

Tasklist

FS#2113 - Bookmark changes

Attached to Project: Rockbox
Opened by Eric Lassauge (lassauge) - Wednesday, 31 March 2004, 10:10 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 14 July 2004, 12:24 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I propose several small but useful changes :

- use creat() instead of open() when creating the
files (or it won't work on at least Cygwin)
- use '.bmk' instead of '.bmark' : keep the 3 letters
extension usage
- use the character 0x91 as the bookmark icon (a little
like a square root sign) for the player

The patch is based on the rockbox-daily-20040329
version.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 14 July 2004, 12:24 GMT
Reason for closing:  Out of Date
Additional comments about closing:  Logged In: YES
user_id=259137

Thanks Eric. This patch is now obsolete, since the open()
works in the simulator nowadays, and I just added a bookmark
icon for the player.
Comment by Björn Stenberg (zagor) - Wednesday, 31 March 2004, 11:08 GMT

Please create patches in unified diff format, using "diff -u".

Why do you want a three-letter extension? We are using
FAT32, which has no such limitations.
Comment by Eric Lassauge (lassauge) - Thursday, 01 April 2004, 12:44 GMT

I know that with the filesystem you can have any
extension you want, but the three-letter extension is
so common (and allready used for every rockbox file : cfg,
wps, lng ....) that I found it more "beautiful" :->
As usual, it's only a proposal ....
Comment by Eric Lassauge (lassauge) - Thursday, 27 May 2004, 16:14 GMT

New version of the patch:
- based on rockbox-daily-20040525
- 'diff -u' used
- stick with 'bmk' extension BUT if you don't like it
take the rest of the patch because it is usefull (creat
and icon for player) ...
Comment by Eric Lassauge (lassauge) - Thursday, 17 June 2004, 09:02 GMT

Updated for rockbox-daily-20040616
Comment by Eric Lassauge (lassauge) - Thursday, 24 June 2004, 12:51 GMT

Updated for rockbox-daily-20040624
Deleted all old patch files ...
Comment by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 14 July 2004, 12:24 GMT

Thanks Eric. This patch is now obsolete, since the open()
works in the simulator nowadays, and I just added a bookmark
icon for the player.

Loading...